[SPARK-5816] Add huge compatibility warning in DriverWrapper#4687
Closed
andrewor14 wants to merge 1 commit intoapache:masterfrom
Closed
[SPARK-5816] Add huge compatibility warning in DriverWrapper#4687andrewor14 wants to merge 1 commit intoapache:masterfrom
andrewor14 wants to merge 1 commit intoapache:masterfrom
Conversation
|
Test build #27705 has started for PR 4687 at commit
|
|
Test build #27705 has finished for PR 4687 at commit
|
|
Test PASSed. |
asfgit
pushed a commit
that referenced
this pull request
Feb 19, 2015
The stability of the new submission gateway assumes that the arguments in `DriverWrapper` are consistent across multiple Spark versions. However, this is not at all clear from the code itself. In fact, this was broken in 20a6013, which is fortunately OK because both that commit and the original commit that added this gateway are part of the same release. To prevent this from happening again we should at the very least add a huge warning where appropriate. Author: Andrew Or <[email protected]> Closes #4687 from andrewor14/driver-wrapper-warning and squashes the following commits: 7989b56 [Andrew Or] Add huge compatibility warning (cherry picked from commit 38e624a) Signed-off-by: Andrew Or <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stability of the new submission gateway assumes that the arguments in
DriverWrapperare consistent across multiple Spark versions. However, this is not at all clear from the code itself. In fact, this was broken in 20a6013, which is fortunately OK because both that commit and the original commit that added this gateway are part of the same release.To prevent this from happening again we should at the very least add a huge warning where appropriate.