[SPARK-46609][SQL] Avoid exponential explosion in PartitioningPreservingUnaryExecNode #44614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
commented
Jan 5, 2024
| final override def outputPartitioning: Partitioning = { | ||
| val partitionings: Seq[Partitioning] = if (hasAlias) { | ||
| flattenPartitioning(child.outputPartitioning).flatMap { | ||
| flattenPartitioning(child.outputPartitioning).iterator.flatMap { |
Contributor
Author
There was a problem hiding this comment.
We apply the threshold when expanding each partitioning inside PartitioningCollection. But if there are many partitionings, we don't limit anything and may produce a lot of partitionings.
Contributor
Author
peter-toth
approved these changes
Jan 5, 2024
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 5, 2024
…ingUnaryExecNode ### What changes were proposed in this pull request? This is a followup of #37525 . When expanding the output partitioning/ordering with aliases, we have a threshold to avoid exponential explosion. However, we missed to apply this threshold in one place. This PR fixes it. ### Why are the changes needed? to avoid OOM ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new test ### Was this patch authored or co-authored using generative AI tooling? no Closes #44614 from cloud-fan/oom. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit f8115da) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to master/3.5. Thank you, @cloud-fan and @peter-toth . |
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…ingUnaryExecNode ### What changes were proposed in this pull request? This is a followup of apache#37525 . When expanding the output partitioning/ordering with aliases, we have a threshold to avoid exponential explosion. However, we missed to apply this threshold in one place. This PR fixes it. ### Why are the changes needed? to avoid OOM ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new test ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44614 from cloud-fan/oom. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit f8115da) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #37525 . When expanding the output partitioning/ordering with aliases, we have a threshold to avoid exponential explosion. However, we missed to apply this threshold in one place. This PR fixes it.
Why are the changes needed?
to avoid OOM
Does this PR introduce any user-facing change?
No
How was this patch tested?
new test
Was this patch authored or co-authored using generative AI tooling?
no