-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-46395][DOCS] Assign Spark configs to groups for use in documentation #44300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 9 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
708e9ad
point to python 3 download
nchammas 7d7f39b
both ruby 1 and 2 are EOL
nchammas be00f99
allow configs to have tags / groups for documentation
nchammas 482f9bc
add method to export all configs with tags to python
nchammas 6747836
add tags to a few configs
nchammas 83b7d69
typo
nchammas 3eff490
replace manual table with generated table
nchammas fb7097f
generate config table per config tag / group
nchammas 807f526
revert heading change for now
nchammas 84e27dc
aqe coalesce partitions -> generated table
nchammas 5dcc747
make anchors unique even if config is repeated
nchammas 88a200c
validate tags with a regex instead
nchammas c7eb234
replace remaining html tables with includes
nchammas 9d9e79b
put generated tables under _generated/
nchammas dda1109
move default processing to separate function
nchammas b8e8f00
prevent break after `#` anchor
nchammas 9d68b41
Merge branch 'master' of github.com:apache/spark into sql-config-groups
nchammas 5adaa4f
tags should be a set, not a list
nchammas f32cd37
Merge branch 'master' of github.com:apache/spark into sql-config-groups
nchammas 88e5ed2
remove unnecessary whitespace
nchammas 2cf958c
remove new section on cbo
nchammas a6d7bab
remove cbo tags
nchammas 9390439
tweak generated table locations and names
nchammas de637da
remove cbo sidebar item
nchammas 9f0db38
automatically tag static vs. runtime sql configs
nchammas c96899b
restore generated-* ignore
nchammas 9656c93
Merge branch 'master' of github.com:apache/spark into sql-config-groups
nchammas 1d7db08
Merge branch 'master' of github.com:apache/spark into sql-config-groups
nchammas 3815b9e
clarify some details with comments
nchammas fa22dd4
Merge branch 'master' of github.com:apache/spark into sql-config-groups
nchammas 7a360b8
Merge branch 'master' into sql-config-groups
nchammas d486ee2
Merge branch 'master' into sql-config-groups
nchammas 0e5401a
use include_api_gen + _generated_config_tables -> _generated/config_t…
nchammas fe7e9d7
generate parent dir too
nchammas 2abe799
Merge branch 'master' into sql-config-groups
nchammas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,28 +34,7 @@ memory usage and GC pressure. You can call `spark.catalog.uncacheTable("tableNam | |
| Configuration of in-memory caching can be done using the `setConf` method on `SparkSession` or by running | ||
| `SET key=value` commands using SQL. | ||
|
|
||
| <table> | ||
| <thead><tr><th>Property Name</th><th>Default</th><th>Meaning</th><th>Since Version</th></tr></thead> | ||
| <tr> | ||
| <td><code>spark.sql.inMemoryColumnarStorage.compressed</code></td> | ||
| <td>true</td> | ||
| <td> | ||
| When set to true, Spark SQL will automatically select a compression codec for each column based | ||
| on statistics of the data. | ||
| </td> | ||
| <td>1.0.1</td> | ||
| </tr> | ||
| <tr> | ||
| <td><code>spark.sql.inMemoryColumnarStorage.batchSize</code></td> | ||
| <td>10000</td> | ||
| <td> | ||
| Controls the size of batches for columnar caching. Larger batch sizes can improve memory utilization | ||
| and compression, but risk OOMs when caching data. | ||
| </td> | ||
| <td>1.1.1</td> | ||
| </tr> | ||
|
|
||
| </table> | ||
| {% include_relative generated-sql-config-table-caching-data.html %} | ||
|
||
|
|
||
| ## Other Configuration Options | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am on the fence regarding this name. Maybe something more explicit like
withDocumentationGroupwould be better?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also do away with custom group names and instead select certain prefixes for use as documentation groups, like
spark.sql.cbo,spark.sql.statistics, etc.However, this won't work for groupings that don't align with config name prefixes, like the breakdown of runtime vs. static configurations that was added in #28274.