[SPARK-43405][SQL] Remove useless getRowFormatSQL, inputRowFormatSQL, outputRowFormatSQL method
#41063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Contributor
|
First, pls write a jira and assign this pr to jira ticket |
Hisoka-X
changed the title
getRowFormatSQL methodgetRowFormatSQL method
Member
Author
Ok, I created SPARK-43405 |
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
This PR actually removes inputRowFormatSQL and outputRowFormatSQL method additionally.
- Could you revise the PR title and description, @Hisoka-X ?
- Do you happen to know when these methods become useless?
Hisoka-X
changed the title
getRowFormatSQL methodgetRowFormatSQL, inputRowFormatSQL, outputRowFormatSQL method
Hisoka-X
changed the title
getRowFormatSQL, inputRowFormatSQL, outputRowFormatSQL methodgetRowFormatSQL, inputRowFormatSQL, outputRowFormatSQL method
Member
Author
Member
|
Thank you for the info, @Hisoka-X . cc @jiangxb1987 and @hvanhovell from #16869 |
Contributor
|
@dongjoon-hyun that is looonnnnggg time ago :) Let me take a look. |
Contributor
|
Merging. |
Member
|
Thank you, @Hisoka-X and @hvanhovell . :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove useless code in class
ScriptInputOutputSchema. IncludegetRowFormatSQL,inputRowFormatSQL,outputRowFormatSQLmethod. It unused when #16869Why are the changes needed?
Clear code.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Unnecessary.