[SPARK-41410][K8S][FOLLOWUP] Remove PVC_COUNTER decrement #38949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @tedyu |
Member
Author
|
For reviewers, the following test case is added. |
Member
Author
|
I'll test this PR more in the cluster. |
Member
Author
|
I already suggest you to use my test code to verify your PR, @tedyu . |
dongjoon-hyun
commented
Dec 7, 2022
Member
Author
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Could you review this follow-up, @viirya ?
viirya
reviewed
Dec 7, 2022
| .inNamespace(namespace) | ||
| .resource(createdExecutorPod) | ||
| .delete() | ||
| PVC_COUNTER.decrementAndGet() |
Member
There was a problem hiding this comment.
This is for case 1, right? For case 2, we don't need to do anything as PVC_COUNTER was not changed for that case?
Member
Author
There was a problem hiding this comment.
Yes, right for case 1 and 2. So, this is a complete and minimal patch, @viirya .
Member
Author
There was a problem hiding this comment.
Since this is used for driver-owned PVCs, the deletion of pods is irrelevant to the number of PVC. That was my logical bug at the initial patch.
Member
Author
|
Thank you so much, @viirya . Merged to master. |
beliefer
pushed a commit
to beliefer/spark
that referenced
this pull request
Dec 18, 2022
### What changes were proposed in this pull request? This is a follow-up to remove `PVC_COUNTER` decrement part to handle exception cases. ### Why are the changes needed? This PR handles the following two cases. 1. If pod creation API throws `KubernetesClientException`, we should not change `PVC_COUNTER`. 2. In case of (1), Spark try to delete pod. If pod deletion API also throws `KubernetesClientException`, we should not change `PVC_COUNTER`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test case. Closes apache#38949 from dongjoon-hyun/SPARK-41410-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up to remove
PVC_COUNTERdecrement part to handle exception cases.Why are the changes needed?
This PR handles the following two cases.
KubernetesClientException, we should not changePVC_COUNTER.KubernetesClientException, we should not changePVC_COUNTER.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test case.