Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 14, 2022

What changes were proposed in this pull request?

This PR is a follow to fix Scala Style error.

Why are the changes needed?

Currently, the all CIs are broken due to this. To recover CIs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

@dongjoon-hyun
Copy link
Member Author

cc @panbingkun , too

@dongjoon-hyun
Copy link
Member Author

Thank you, @MaxGekk . I manually verified this PR. Merged to master to recover the CIs (including PR builders).

$ dev/scalastyle
Using SPARK_LOCAL_IP=localhost
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
SLF4J: Class path contains SLF4J bindings targeting slf4j-api versions 1.7.x or earlier.
SLF4J: Ignoring binding found at [jar:file:/Users/dongjoon/.sbt/boot/scala-2.12.17/org.scala-sbt/sbt/1.7.3/log4j-slf4j-impl-2.17.1.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See https://www.slf4j.org/codes.html#ignoredBindings for an explanation.
Scalastyle checks passed.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-41109 branch November 14, 2022 06:57
@MaxGekk
Copy link
Member

MaxGekk commented Nov 14, 2022

Thank you, @dongjoon-hyun for the quick fix.

SandishKumarHN pushed a commit to SandishKumarHN/spark that referenced this pull request Dec 12, 2022
### What changes were proposed in this pull request?

This PR is a follow to fix Scala Style error.

### Why are the changes needed?

Currently, the all CIs are broken due to this. To recover CIs.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

Closes apache#38645 from dongjoon-hyun/SPARK-41109.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants