Skip to content

[Minor] Fix a typo of type parameter in JavaUtils.scala #3789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sarutak wants to merge 3 commits into from
Closed

[Minor] Fix a typo of type parameter in JavaUtils.scala #3789

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
99f6f63
Fixed a typo of type parameter in JavaUtils.scala
sarutak Dec 24, 2014
82bc5d9
Merge branch 'master' of git://git.apache.org/spark into fix-typo-in-…
sarutak Dec 24, 2014
e20193d
Fixed a typo of type parameter
sarutak Dec 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/scala/org/apache/spark/api/java/JavaUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private[spark] object JavaUtils {
prev match {
case Some(k) =>
underlying match {
case mm: mutable.Map[a, _] =>
case mm: mutable.Map[_, _] =>
Copy link
Member

@srowen srowen Dec 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this really be A to express the relation to the generic bound? although underlying must already have keys of type A already. It just looks like that was the intent.

Copy link
Member Author

@sarutak sarutak Dec 24, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought it should be A but the type parameter at the position is no mean because the erasure removes type information at the time of compile.
Even though, should we place A for readability?

mm remove k
prev = None
case _ =>
Expand Down