Skip to content

Conversation

@peter-toth
Copy link
Contributor

What changes were proposed in this pull request?

There might be SparkPlan nodes where canonicalization on executor side can cause issues. This is a follow-up fix to conversation https://github.com/apache/spark/pull/32885/files#r651019687.

Why are the changes needed?

To avoid potential NPEs when canonicalization happens on executors.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Existing UTs.

@peter-toth
Copy link
Contributor Author

cc @cloud-fan

@SparkQA
Copy link

SparkQA commented Jun 17, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44447/

@SparkQA
Copy link

SparkQA commented Jun 17, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44447/

@cloud-fan
Copy link
Contributor

thanks for the cleanup! merging to master

@cloud-fan cloud-fan closed this in abf9675 Jun 17, 2021
@SparkQA
Copy link

SparkQA commented Jun 17, 2021

Test build #139919 has finished for PR 32947 at commit 6caeef1.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@peter-toth
Copy link
Contributor Author

Thanks for the review.

@HyukjinKwon
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants