Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Jun 2, 2021

What changes were proposed in this pull request?

This pr upgrades built-in Hive to 2.3.9. Hive 2.3.9 changes:

  • [HIVE-17155] - findConfFile() in HiveConf.java has some issues with the conf path
  • [HIVE-24797] - Disable validate default values when parsing Avro schemas
  • [HIVE-24608] - Switch back to get_table in HMS client for Hive 2.3.x
  • [HIVE-21200] - Vectorization: date column throwing java.lang.UnsupportedOperationException for parquet
  • [HIVE-21563] - Improve Table#getEmptyTable performance by disabling registerAllFunctionsOnce
  • [HIVE-19228] - Remove commons-httpclient 3.x usage

Why are the changes needed?

Fix regression caused by AVRO-2035.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Unit test.

@wangyum wangyum marked this pull request as draft June 2, 2021 13:17
@wangyum
Copy link
Member Author

wangyum commented Jun 2, 2021

cc @sunchao

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43750/

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43750/

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Test build #139227 has finished for PR 32750 at commit 570dc84.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

Thank you, @wangyum . It seems that the downloading still have some issue.

sbt.ForkMain$ForkError: java.lang.RuntimeException: [unresolved dependency: org.apache.hive.hcatalog#hive-hcatalog-core;2.3.9: not found]
	at org.apache.spark.deploy.SparkSubmitUtils$.resolveMavenCoordinates(SparkSubmit.scala:1446)

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Test build #139246 has finished for PR 32750 at commit d48df90.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 2, 2021

Kubernetes integration test unable to build dist.

exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43769/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43770/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43770/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Test build #139247 has finished for PR 32750 at commit f81813f.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43782/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/43782/

@SparkQA
Copy link

SparkQA commented Jun 3, 2021

Test build #139258 has finished for PR 32750 at commit c7194cf.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@wangyum wangyum changed the title [SPARK-33696][BUILD][SQL] Upgrade built-in Hive to 2.3.9 [SPARK-34512][BUILD][SQL] Upgrade built-in Hive to 2.3.9 Jun 3, 2021
@dongjoon-hyun
Copy link
Member

Hi, @wangyum .

@sunchao uploaded Apache Hive 2.3.9 to the Maven Central. Could you revise this PR?

@wangyum wangyum marked this pull request as ready for review June 10, 2021 23:21
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending CIs)
Thank you for updating.

@SparkQA
Copy link

SparkQA commented Jun 11, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44191/

@SparkQA
Copy link

SparkQA commented Jun 11, 2021

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44191/

@SparkQA
Copy link

SparkQA commented Jun 11, 2021

Test build #139663 has finished for PR 32750 at commit ff0170e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jun 11, 2021

Merged to master for Apache Spark 3.2.0.
Thank you so much, @wangyum , @srowen and @sunchao !

@wangyum wangyum deleted the SPARK-34512 branch June 11, 2021 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants