Skip to content

[SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions #32499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
AngersZhuuuu wants to merge 3 commits into from
Closed

[SPARK-29145][SQL][FOLLOWUP] Clean up code about support sub-queries in join conditions #32499

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
504f821
Update Analyzer.scala
AngersZhuuuu May 11, 2021
3aa629b
Update Analyzer.scala
AngersZhuuuu May 11, 2021
d9cad03
Update Analyzer.scala
AngersZhuuuu May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2353,7 +2353,7 @@ class Analyzer(override val catalogManager: CatalogManager)
case q: UnaryNode if q.childrenResolved =>
resolveSubQueries(q, q.children)
case j: Join if j.childrenResolved =>
Copy link
Contributor

@cloud-fan cloud-fan May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems we should also check j.duplicateResolved

Copy link
Contributor Author

@AngersZhuuuu AngersZhuuuu May 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, but I am confused witch case will cause error.

resolveSubQueries(j, Seq(j, j.left, j.right))
resolveSubQueries(j, j.children)
case s: SupportsSubquery if s.childrenResolved =>
resolveSubQueries(s, s.children)
}
Expand Down