-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][SQL] Spelling: enabled - legacy_setops_precedence_enbled #30677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Josh Soref <[email protected]>
|
Happy to do so if people are ok with them. I split because I had no idea which items would be controversial. |
|
See comments by @srowen @cloud-fan 6cbd74162a77fdc4c04c867952ec42c6e493288b |
|
ok to test |
|
looks fine. |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
|
Test build #132461 has finished for PR 30677 at commit
|
|
Jenkins retest this please |
|
Test build #132580 has finished for PR 30677 at commit
|
|
retest this please |
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #132599 has finished for PR 30677 at commit
|
|
thanks, merging to master! |
What changes were proposed in this pull request?
Replace
legacy_setops_precedence_enbledwithlegacy_setops_precedence_enabledAlternatively,
legacy_setops_precedence_enabledcould be added, andlegacy_setops_precedence_enbledretained, and if set the code could honor it and warn about the deprecated spelling.Why are the changes needed?
enabledis misspelled inlegacy_setops_precedence_enbledDoes this PR introduce any user-facing change?
Yes.
It would break current consumers.
Examples include:
How was this patch tested?
It's been included in #30323 for a while (and is now split out here)