Skip to content

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Dec 9, 2020

What changes were proposed in this pull request?

Replace legacy_setops_precedence_enbled with legacy_setops_precedence_enabled

Alternatively, legacy_setops_precedence_enabled could be added, and legacy_setops_precedence_enbled retained, and if set the code could honor it and warn about the deprecated spelling.

Why are the changes needed?

enabled is misspelled in legacy_setops_precedence_enbled

Does this PR introduce any user-facing change?

Yes.

It would break current consumers.
Examples include:

How was this patch tested?

It's been included in #30323 for a while (and is now split out here)

Signed-off-by: Josh Soref <[email protected]>
@github-actions github-actions bot added the SQL label Dec 9, 2020
@HyukjinKwon HyukjinKwon changed the title [API] spelling: enabled - legacy_setops_precedence_enbled [MINOR][SQL] Spelling: enabled - legacy_setops_precedence_enbled Dec 9, 2020
@HyukjinKwon
Copy link
Member

I think you can combine #30680 and #30678 here

@jsoref
Copy link
Contributor Author

jsoref commented Dec 9, 2020

Happy to do so if people are ok with them. I split because I had no idea which items would be controversial.

@jsoref
Copy link
Contributor Author

jsoref commented Dec 9, 2020

See comments by @srowen @cloud-fan 6cbd74162a77fdc4c04c867952ec42c6e493288b

@cloud-fan
Copy link
Contributor

ok to test

@maropu
Copy link
Member

maropu commented Dec 9, 2020

looks fine.

@SparkQA
Copy link

SparkQA commented Dec 9, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37063/

@SparkQA
Copy link

SparkQA commented Dec 9, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37063/

@SparkQA
Copy link

SparkQA commented Dec 9, 2020

Test build #132461 has finished for PR 30677 at commit 50c0c46.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Dec 10, 2020

Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Dec 10, 2020

Test build #132580 has finished for PR 30677 at commit 50c0c46.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Dec 11, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37204/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37204/

@SparkQA
Copy link

SparkQA commented Dec 11, 2020

Test build #132599 has finished for PR 30677 at commit 50c0c46.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

thanks, merging to master!

@cloud-fan cloud-fan closed this in c05f6f9 Dec 11, 2020
@jsoref jsoref deleted the spelling-enabled branch December 11, 2020 15:52
@jsoref jsoref mentioned this pull request Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants