Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Nov 26, 2020

What changes were proposed in this pull request?

This PR proposes to keep the test coverage with Python 3.8 in GitHub Actions. It is not tested for now in Jenkins due to an env issue.

Before this change in GitHub Actions:

========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
Will test against the following Python executables: ['python3.6', 'pypy3']
...

After this change in GitHub Actions:

========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
Will test against the following Python executables: ['python3.6', 'python3.8', 'pypy3']

Why are the changes needed?

To keep the test coverage with Python 3.8 in GitHub Actions.

Does this PR introduce any user-facing change?

No, dev-only.

How was this patch tested?

GitHub Actions in this build will test.

@github-actions github-actions bot added the BUILD label Nov 26, 2020
@HyukjinKwon
Copy link
Member Author

cc @dongjoon-hyun and @shaneknapp

@shaneknapp
Copy link
Contributor

lgtm!

@HyukjinKwon
Copy link
Member Author

GA passed. Merging to master. Thanks @shaneknapp!

@SparkQA
Copy link

SparkQA commented Nov 26, 2020

Test build #131821 has finished for PR 30510 at commit 31755d9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

HyukjinKwon added a commit that referenced this pull request Nov 26, 2020
…on 3.8 in GitHub Actions

### What changes were proposed in this pull request?

This is a backport PR of #30510

This PR proposes to keep the test coverage with Python 3.8 in GitHub Actions. It is not tested for now in Jenkins due to an env issue.

**Before this change in GitHub Actions:**

```
========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
Will test against the following Python executables: ['/usr/bin/python3', 'python2.7', 'pypy3']
...
```

**After this change in GitHub Actions:**

```

========================================================================
Running PySpark tests
========================================================================
Running PySpark tests. Output is in /__w/spark/spark/python/unit-tests.log
Will test against the following Python executables: ['python3.8', 'python2.7', 'pypy3']
```

### Why are the changes needed?

To keep the test coverage with Python 3.8 in GitHub Actions.

### Does this PR introduce _any_ user-facing change?

No, dev-only.

### How was this patch tested?

GitHub Actions in this build will test.

Closes #30511 from HyukjinKwon/SPARK-33565-3.0.

Authored-by: HyukjinKwon <[email protected]>
Signed-off-by: HyukjinKwon <[email protected]>
@dongjoon-hyun
Copy link
Member

+1, late LGTM.

@HyukjinKwon HyukjinKwon deleted the SPARK-33565 branch December 7, 2020 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants