Skip to content

Conversation

@zero323
Copy link
Member

@zero323 zero323 commented Nov 25, 2020

What changes were proposed in this pull request?

This PR adds the following functions (introduced in Scala API with SPARK-33061):

  • acosh
  • asinh
  • atanh

to Python and R.

Why are the changes needed?

Feature parity.

Does this PR introduce any user-facing change?

New functions.

How was this patch tested?

New unit tests.

@zero323
Copy link
Member Author

zero323 commented Nov 25, 2020

cc @rwpenney.

@SparkQA
Copy link

SparkQA commented Nov 25, 2020

Test build #131787 has finished for PR 30501 at commit d1c7cf8.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 25, 2020

Test build #131801 has finished for PR 30501 at commit 6165ba3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

column(jc)
})

#' @details
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zero323, should we add them into generic.R too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All trig functions are already generic, so we don't need that here.

@HyukjinKwon
Copy link
Member

Looks fine otherwise.

@SparkQA
Copy link

SparkQA commented Nov 26, 2020

Test build #131842 has finished for PR 30501 at commit 17451c7.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

Merged to master.

@zero323
Copy link
Member Author

zero323 commented Nov 27, 2020

Thanks @HyukjinKwon @srowen!

@zero323 zero323 deleted the SPARK-33563 branch November 27, 2020 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants