-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-33563][PYTHON][R][SQL] Expose inverse hyperbolic trig functions in PySpark and SparkR #30501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @rwpenney. |
|
Test build #131787 has finished for PR 30501 at commit
|
|
Test build #131801 has finished for PR 30501 at commit
|
| column(jc) | ||
| }) | ||
|
|
||
| #' @details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zero323, should we add them into generic.R too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All trig functions are already generic, so we don't need that here.
|
Looks fine otherwise. |
|
Test build #131842 has finished for PR 30501 at commit
|
|
Merged to master. |
|
Thanks @HyukjinKwon @srowen! |
What changes were proposed in this pull request?
This PR adds the following functions (introduced in Scala API with SPARK-33061):
acoshasinhatanhto Python and R.
Why are the changes needed?
Feature parity.
Does this PR introduce any user-facing change?
New functions.
How was this patch tested?
New unit tests.