[SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script #30487

LuciferYang · 2020-11-24T14:25:41Z

What changes were proposed in this pull request?

It seems that Jenkins tests tasks in many pr have test failed. The failed cases include:

org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V2 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V3 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V4 get binary type
org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V5 get binary type

The error message as follows:

Error Messageorg.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�]("Stacktracesbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�]("
	at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472)
	at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471)
	at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231)
	at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295)
	at org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.$anonfun$new$26(SparkThriftServerProtocolVersionsSuite.scala:302)

But they can pass the GitHub Action, maybe it's related to the LANG of the Jenkins build machine, this pr add export LANG="en_US.UTF-8" in run-test-jenkins script.

Why are the changes needed?

Ensure LANG in Jenkins test process is en_US.UTF-8 to pass HIVE_CLI_SERVICE_PROTOCOL_VX related tests

Does this PR introduce any user-facing change?

No

How was this patch tested?

Jenkins tests pass

LuciferYang · 2020-11-24T14:30:04Z

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131634/testReport/org.apache.spark.sql.hive.thriftserver/SparkThriftServerProtocolVersionsSuite/HIVE_CLI_SERVICE_PROTOCOL_V1_get_binary_type/

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131659/testReport/org.apache.spark.sql.hive.thriftserver/SparkThriftServerProtocolVersionsSuite/HIVE_CLI_SERVICE_PROTOCOL_V1_get_binary_type/

https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/131619/testReport/org.apache.spark.sql.hive.thriftserver/SparkThriftServerProtocolVersionsSuite/HIVE_CLI_SERVICE_PROTOCOL_V1_get_binary_type/

LuciferYang · 2020-11-24T14:31:43Z

Wait for Jenkins test to verify the results

dongjoon-hyun · 2020-11-24T16:46:28Z

Thank you for investigating, @LuciferYang .

dongjoon-hyun

+1, LGTM. Thank you, @LuciferYang .
This passed Scala/Java/Python tests already. I'll merge this.

…enkins script ### What changes were proposed in this pull request? It seems that Jenkins tests tasks in many pr have test failed. The failed cases include: - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V2 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V3 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V4 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V5 get binary type` The error message as follows: ``` Error Messageorg.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�]("Stacktracesbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�](" at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472) at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471) at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231) at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295) at org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.$anonfun$new$26(SparkThriftServerProtocolVersionsSuite.scala:302) ``` But they can pass the GitHub Action, maybe it's related to the `LANG` of the Jenkins build machine, this pr add `export LANG="en_US.UTF-8"` in `run-test-jenkins` script. ### Why are the changes needed? Ensure LANG in Jenkins test process is `en_US.UTF-8` to pass `HIVE_CLI_SERVICE_PROTOCOL_VX` related tests ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Jenkins tests pass Closes #30487 from LuciferYang/SPARK-33535. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 048a982) Signed-off-by: Dongjoon Hyun <[email protected]>

…enkins script It seems that Jenkins tests tasks in many pr have test failed. The failed cases include: - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V1 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V2 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V3 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V4 get binary type` - `org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.HIVE_CLI_SERVICE_PROTOCOL_V5 get binary type` The error message as follows: ``` Error Messageorg.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�]("Stacktracesbt.ForkMain$ForkError: org.scalatest.exceptions.TestFailedException: "[?](" did not equal "[�](" at org.scalatest.Assertions.newAssertionFailedException(Assertions.scala:472) at org.scalatest.Assertions.newAssertionFailedException$(Assertions.scala:471) at org.scalatest.Assertions$.newAssertionFailedException(Assertions.scala:1231) at org.scalatest.Assertions$AssertionsHelper.macroAssert(Assertions.scala:1295) at org.apache.spark.sql.hive.thriftserver.SparkThriftServerProtocolVersionsSuite.$anonfun$new$26(SparkThriftServerProtocolVersionsSuite.scala:302) ``` But they can pass the GitHub Action, maybe it's related to the `LANG` of the Jenkins build machine, this pr add `export LANG="en_US.UTF-8"` in `run-test-jenkins` script. Ensure LANG in Jenkins test process is `en_US.UTF-8` to pass `HIVE_CLI_SERVICE_PROTOCOL_VX` related tests No Jenkins tests pass Closes #30487 from LuciferYang/SPARK-33535. Authored-by: yangjie01 <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 048a982) Signed-off-by: Dongjoon Hyun <[email protected]>

dongjoon-hyun · 2020-11-24T17:53:01Z

Merged to master/branch-3.0/branch-2.4.

SparkQA · 2020-11-24T18:09:07Z

Test build #131669 has finished for PR 30487 at commit 5c90411.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

LuciferYang · 2020-11-25T02:20:59Z

@dongjoon-hyun thx ~

HyukjinKwon · 2020-11-25T03:46:01Z

Oh, I see. nice. @wangyum FYI

HyukjinKwon

Nice, late LGTM too

LuciferYang · 2020-11-25T04:55:39Z

thx ~ @HyukjinKwon :)

export LANG to en_US.UTF-8

5c90411

LuciferYang marked this pull request as draft November 24, 2020 14:25

LuciferYang changed the title ~~[WIP][SPARK-33535][BUILD] Export LANG to en_US.UTF-8 in run-tests-jenkins script~~ [SPARK-33535][BUILD] Export LANG to en_US.UTF-8 in run-tests-jenkins script Nov 24, 2020

LuciferYang marked this pull request as ready for review November 24, 2020 14:32

github-actions bot added BUILD INFRA labels Nov 24, 2020

dongjoon-hyun changed the title ~~[SPARK-33535][BUILD] Export LANG to en_US.UTF-8 in run-tests-jenkins script~~ [SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script Nov 24, 2020

dongjoon-hyun approved these changes Nov 24, 2020

View reviewed changes

dongjoon-hyun closed this in 048a982 Nov 24, 2020

HyukjinKwon reviewed Nov 25, 2020

View reviewed changes

LuciferYang deleted the SPARK-33535 branch June 6, 2022 03:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script #30487

[SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script #30487

Uh oh!

LuciferYang commented Nov 24, 2020 •

edited

Loading

Uh oh!

LuciferYang commented Nov 24, 2020

Uh oh!

LuciferYang commented Nov 24, 2020

Uh oh!

dongjoon-hyun commented Nov 24, 2020

Uh oh!

dongjoon-hyun left a comment

Uh oh!

dongjoon-hyun commented Nov 24, 2020

Uh oh!

SparkQA commented Nov 24, 2020

Uh oh!

LuciferYang commented Nov 25, 2020

Uh oh!

HyukjinKwon commented Nov 25, 2020

Uh oh!

HyukjinKwon left a comment

Uh oh!

LuciferYang commented Nov 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script #30487

[SPARK-33535][INFRA][TESTS] Export LANG to en_US.UTF-8 in run-tests-jenkins script #30487

Uh oh!

Conversation

LuciferYang commented Nov 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Uh oh!

LuciferYang commented Nov 24, 2020

Uh oh!

LuciferYang commented Nov 24, 2020

Uh oh!

dongjoon-hyun commented Nov 24, 2020

Uh oh!

dongjoon-hyun left a comment

Choose a reason for hiding this comment

Uh oh!

dongjoon-hyun commented Nov 24, 2020

Uh oh!

SparkQA commented Nov 24, 2020

Uh oh!

LuciferYang commented Nov 25, 2020

Uh oh!

HyukjinKwon commented Nov 25, 2020

Uh oh!

HyukjinKwon left a comment

Choose a reason for hiding this comment

Uh oh!

LuciferYang commented Nov 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LuciferYang commented Nov 24, 2020 •

edited

Loading