-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-33525][SQL] Update hive-service-rpc to 3.1.2 #30478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/thrift/ThriftCLIService.java
Show resolved
Hide resolved
...-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala
Show resolved
Hide resolved
| <groupId>${hive.group}</groupId> | ||
| <artifactId>hive-service-rpc</artifactId> | ||
| <version>${hive.version}</version> | ||
| <version>3.1.2</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we have a JIRA to recover this when we upgrade Hive version to 3.1.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangyum . Did you create a JIRA? I cannot find it yet. If you created, please link to SPARK-33525 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
cc @juliuszsompolski FYI since you're working on this area. |
|
Test build #131619 has finished for PR 30478 at commit
|
|
Retest this please |
|
The Hive Thrift Server UT failure was due to the Jenkins Server change and it's fixed at master. |
|
Retest this please |
|
Test build #131679 has finished for PR 30478 at commit
|
|
Test build #131688 has finished for PR 30478 at commit
|
|
Retest this please |
|
Test build #131702 has finished for PR 30478 at commit
|
|
retest this please |
|
Test build #131720 has finished for PR 30478 at commit
|
|
retest this please. |
|
Test build #131734 has finished for PR 30478 at commit
|
|
Retest this please |
|
Test build #131755 has finished for PR 30478 at commit
|
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @wangyum .
I verified this manually with the given example.
apache-hive-3.1.2-bin:$ bin/beeline -u jdbc:hive2://localhost:10000/default
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in [jar:file:/Users/dongjoon/APACHE/hive-release/apache-hive-3.1.2-bin/lib/log4j-slf4j-impl-2.10.0.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in [jar:file:/Users/dongjoon/APACHE/hadoop-release/hadoop-3.2.0/share/hadoop/common/lib/slf4j-log4j12-1.7.25.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation.
SLF4J: Actual binding is of type [org.apache.logging.slf4j.Log4jLoggerFactory]
Connecting to jdbc:hive2://localhost:10000/default
Connected to: Spark SQL (version 3.1.0-SNAPSHOT)
Driver: Hive JDBC (version 3.1.2)
Transaction isolation: TRANSACTION_REPEATABLE_READ
Beeline version 3.1.2 by Apache Hive
0: jdbc:hive2://localhost:10000/default> create table t1(id int) using parquet;
+---------+
| Result |
+---------+
+---------+
No rows selected (4.151 seconds)
0: jdbc:hive2://localhost:10000/default> select * from t1;
+-----+
| id |
+-----+
+-----+
No rows selected (1.465 seconds)
0: jdbc:hive2://localhost:10000/default>
|
Nice! |
What changes were proposed in this pull request?
We supported Hive metastore are 0.12.0 through 3.1.2, but we supported hive-jdbc are 0.12.0 through 2.3.7. It will throw
TProtocolExceptionif we use hive-jdbc 3.x:This pr upgrade hive-service-rpc to 3.1.2 to fix this issue.
Why are the changes needed?
To support hive-jdbc 3.x.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test: