[SPARK-33464][INFRA][3.0] Add/remove (un)necessary cache and restructure GitHub Actions yaml #30416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itHub Actions yaml This PR proposes: - Add `~/.sbt` directory into the build cache, see also sbt/sbt#3681 - Move `hadoop-2` below to put up together with `java-11` and `scala-213`, see apache#30391 (comment) - Remove unnecessary `.m2` cache if you run SBT tests only. - Remove `rm ~/.m2/repository/org/apache/spark`. If you don't `sbt publishLocal` or `mvn install`, we don't need to care about it. - Use Java 8 in Scala 2.13 build. We can switch the Java version to 11 used for release later. - Add caches into linters. The linter scripts uses `sbt` in, for example, `./dev/lint-scala`, and uses `mvn` in, for example, `./dev/lint-java`. Also, it requires to `sbt package` in Jekyll build, see: https://github.com/apache/spark/blob/master/docs/_plugins/copy_api_dirs.rb#L160-L161. We need full caches here for SBT, Maven and build tools. - Use the same syntax of Java version, 1.8 -> 8. - Remove unnecessary stuff - Cache what we can in the build No, dev-only. It will be tested in GitHub Actions build at the current PR Closes apache#30391 from HyukjinKwon/SPARK-33464. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
|
Test build #131310 has finished for PR 30416 at commit
|
dongjoon-hyun
approved these changes
Nov 19, 2020
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. (Pending GitHub Action)
Member
Author
|
Thanks @dongjoon-hyun! |
|
Kubernetes integration test starting |
|
Kubernetes integration test status success |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Nov 19, 2020
…ure GitHub Actions yaml ### What changes were proposed in this pull request? This PR backports #30391. Note that it's a partial backport. This PR proposes: - Add `~/.sbt` directory into the build cache, see also sbt/sbt#3681 - ~Move `hadoop-2` below to put up together with `java-11` and `scala-213`, see #30391 (comment) - Remove unnecessary `.m2` cache if you run SBT tests only. - Remove `rm ~/.m2/repository/org/apache/spark`. If you don't `sbt publishLocal` or `mvn install`, we don't need to care about it. - ~Use Java 8 in Scala 2.13 build. We can switch the Java version to 11 used for release later.~ - Add caches into linters. The linter scripts uses `sbt` in, for example, `./dev/lint-scala`, and uses `mvn` in, for example, `./dev/lint-java`. Also, it requires to `sbt package` in Jekyll build, see: https://github.com/apache/spark/blob/master/docs/_plugins/copy_api_dirs.rb#L160-L161. We need full caches here for SBT, Maven and build tools. - Use the same syntax of Java version, 1.8 -> 8. ### Why are the changes needed? - Remove unnecessary stuff - Cache what we can in the build ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? It will be tested in GitHub Actions build at the current PR Closes #30416 from HyukjinKwon/SPARK-33464-3.0. Authored-by: HyukjinKwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Merged to branch-3.0. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR backports #30391. Note that it's a partial backport.
This PR proposes:
~/.sbtdirectory into the build cache, see also Directory standard sbt/sbt#3681Movehadoop-2below to put up together withjava-11andscala-213, see [SPARK-33464][INFRA] Add/remove (un)necessary cache and restructure GitHub Actions yaml #30391 (comment).m2cache if you run SBT tests only.rm ~/.m2/repository/org/apache/spark. If you don'tsbt publishLocalormvn install, we don't need to care about it.Use Java 8 in Scala 2.13 build. We can switch the Java version to 11 used for release later.sbtin, for example,./dev/lint-scala, and usesmvnin, for example,./dev/lint-java. Also, it requires tosbt packagein Jekyll build, see: https://github.com/apache/spark/blob/master/docs/_plugins/copy_api_dirs.rb#L160-L161. We need full caches here for SBT, Maven and build tools.Why are the changes needed?
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
It will be tested in GitHub Actions build at the current PR