Skip to content

[MINOR][GRAPHX] Correct typos in the sub-modules: graphx, external, and examples #30326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jsoref wants to merge 13 commits into from
Closed

[MINOR][GRAPHX] Correct typos in the sub-modules: graphx, external, and examples #30326

jsoref wants to merge 13 commits into from

Conversation

@jsoref
Copy link
Contributor

@jsoref jsoref commented Nov 11, 2020 •
edited by maropu
Loading

What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per @holdenk #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Why are the changes needed?

Misspelled words make it harder to read / understand content.

Does this PR introduce any user-facing change?

No

How was this patch tested?

No testing was performed

@jsoref
spelling: offset
7853316 
Signed-off-by: Josh Soref <[email protected]>
@maropu
Copy link
Member

maropu commented Nov 11, 2020

ok to test

@maropu
Copy link
Member

maropu commented Nov 11, 2020 •
edited
Loading

Since examples and external are not updated actively, too, could you add typo fixes for them in this PR?
https://gist.github.com/maropu/c737f1a40ea48758d8bb397bc078dc68#file-gistfile1-txt-L123-L148

@maropu maropu changed the title spelling: offset [MINOR][GRAPHX] Correct typos Nov 11, 2020
@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Test build #130905 has finished for PR 30326 at commit 7853316.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35511/

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35511/

@maropu maropu changed the title [MINOR][GRAPHX] Correct typos [MINOR][GRAPHX] Correct typos in the sub-modules: graphx, external, and examples Nov 11, 2020
@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Test build #130916 has finished for PR 30326 at commit 4203606.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

jsoref added 12 commits November 11, 2020 03:00
@jsoref
spelling: depends
595a252 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: e.g.
cbb4c86 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: expected
2730502 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: external
bd57831 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: i.e.
1cf7aa2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: manager
bdcd89c 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: otherwise
1b0870d 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: perform
6d3ab96 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: series
00efb56 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: struct
3fe0d85 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: transactional
45857d2 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
spelling: whether
21be1af 
Signed-off-by: Josh Soref <[email protected]>
@jsoref
Copy link
Contributor Author

jsoref commented Nov 11, 2020

Dropped 60ccc95 as it was dependent on the part of 894462594ad52fae13bb8481e001b4a66ed818a9 that's outside this scope.

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35521/

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35521/

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35524/

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Test build #130919 has finished for PR 30326 at commit 21be1af.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 11, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/35524/

@jsoref jsoref mentioned this pull request Nov 11, 2020
Closed
@maropu maropu closed this in 9d58a2f Nov 11, 2020
@maropu
Copy link
Member

maropu commented Nov 11, 2020

Thanks! Merged to master. Could you open a PR to backport this into branch-3.0/2.4? Minor though, it would be nice to fix them there, too, for better code quality.

jsoref added a commit to jsoref/spark that referenced this pull request Nov 12, 2020
@jsoref
[MINOR][GRAPHX] Correct typos in the sub-modules: graphx, external, a…
77f2623 
…nd examples

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per holdenk apache#30323 (comment)

NOTE: The misspellings have been reported at 706a726#commitcomment-44064356

Misspelled words make it harder to read / understand content.

No

No testing was performed

Closes apache#30326 from jsoref/spelling-graphx.

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
jsoref added a commit to jsoref/spark that referenced this pull request Nov 12, 2020
@jsoref
[MINOR][GRAPHX] Correct typos in the sub-modules: graphx, external, a…
64effa1 
…nd examples

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per holdenk apache#30323 (comment)

NOTE: The misspellings have been reported at 706a726#commitcomment-44064356

Misspelled words make it harder to read / understand content.

No

No testing was performed

Closes apache#30326 from jsoref/spelling-graphx.

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
This was referenced Nov 12, 2020
Closed
Closed
maropu pushed a commit that referenced this pull request Nov 12, 2020
@jsoref @maropu
[MINOR][GRAPHX][2.4] Correct typos in the sub-modules: graphx, extern…
1e177c7 
…al, and examples

### What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per holdenk #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Backport of #30326

### Why are the changes needed?

Misspelled words make it harder to read / understand content.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No testing was performed

Closes #30343 from jsoref/branch-2.4-30326.

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
maropu pushed a commit that referenced this pull request Nov 17, 2020
@jsoref @maropu
[MINOR][GRAPHX][3.0] Correct typos in the sub-modules: graphx, extern…
26c0404 
…al, and examples

### What changes were proposed in this pull request?

This PR intends to fix typos in the sub-modules: graphx, external, and examples.
Split per holdenk #30323 (comment)

NOTE: The misspellings have been reported at jsoref@706a726#commitcomment-44064356

Backport of #30326

### Why are the changes needed?

Misspelled words make it harder to read / understand content.

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

No testing was performed

Closes #30342 from jsoref/branch-3.0-30326.

Authored-by: Josh Soref <[email protected]>
Signed-off-by: Takeshi Yamamuro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maropu maropu maropu approved these changes

@srowen srowen srowen approved these changes

Assignees

No one assigned

Labels

EXAMPLES GRAPHX ML PYTHON SQL STRUCTURED STREAMING

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsoref @maropu @SparkQA @srowen