Skip to content

[SPARK-32688][SQL][TEST] Add special values to LiteralGenerator for float and double #29515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tanelk wants to merge 8 commits into from
Closed

[SPARK-32688][SQL][TEST] Add special values to LiteralGenerator for float and double #29515

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8c8313c
Add special values to LiteralGenerator for float and double
tanelk Aug 22, 2020
77d63ac
Add 'MaxValue' to LiteralGenerator for float and double
tanelk Aug 23, 2020
818abe2
Ensure -0.0 and 0.0 comparison consistency
tanelk Aug 23, 2020
1116d3d
Revert equality check
tanelk Aug 23, 2020
2dce36e
test -0.0 equality for complex types
tanelk Aug 23, 2020
9a3b983
Add -0.0 as special value to RandomDataGenerator
tanelk Aug 24, 2020
d20a2ed
revert test -0.0 equality for complex types
tanelk Sep 4, 2020
529aba8
revert test -0.0 equality for complex types
tanelk Sep 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralGenerator.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,22 @@ object LiteralGenerator {

lazy val floatLiteralGen: Gen[Literal] =
for {
f <- Gen.chooseNum(Float.MinValue / 2, Float.MaxValue / 2,
Float.NaN, Float.PositiveInfinity, Float.NegativeInfinity)
f <- Gen.oneOf(
Gen.oneOf(
Float.NaN, Float.PositiveInfinity, Float.NegativeInfinity, Float.MinPositiveValue,
0.0f, -0.0f, 1.0f, -1.0f),
Copy link
Member

@maropu maropu Aug 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are 1.0f and -1.0f also special values?

Copy link
Contributor Author

@tanelk tanelk Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They aren't in the sense, that Arbitrary.arbFloat.arbitrary can generate them, but they are in the sense, that it is more likely, that a function could act weirdly at these values. For example log1p.

Copy link
Member

@maropu maropu Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you leave some comments in the code?

Copy link
Contributor Author

@tanelk tanelk Aug 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Arbitrary.arbFloat.arbitrary
)
} yield Literal.create(f, FloatType)

lazy val doubleLiteralGen: Gen[Literal] =
for {
f <- Gen.chooseNum(Double.MinValue / 2, Double.MaxValue / 2,
Double.NaN, Double.PositiveInfinity, Double.NegativeInfinity)
f <- Gen.oneOf(
Gen.oneOf(
Double.NaN, Double.PositiveInfinity, Double.NegativeInfinity, Double.MinPositiveValue,
0.0, -0.0, 1.0, -1.0),
Arbitrary.arbDouble.arbitrary
)
} yield Literal.create(f, DoubleType)

// TODO cache the generated data
Expand Down