Skip to content

Conversation

@holdenk
Copy link
Contributor

@holdenk holdenk commented Aug 19, 2020

What changes were proposed in this pull request?

Update the log strings to match the new log messages.

Why are the changes needed?

Tests are failing

Does this PR introduce any user-facing change?

No, test only change.

How was this patch tested?

WIP: Make sure the DecommissionSuite passes in Jenkins.

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Test build #127655 has finished for PR 29479 at commit 4532e5d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32278/

@holdenk
Copy link
Contributor Author

holdenk commented Aug 19, 2020

cc @dongjoon-hyun

@dongjoon-hyun
Copy link
Member

Thank you, @holdenk .

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32278/

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM (Pending K8s IT)

@dongjoon-hyun
Copy link
Member

Oh, does it fail?

@holdenk
Copy link
Contributor Author

holdenk commented Aug 19, 2020

Huh this is weird that's not something I was expecting ( [ERROR] [Error] /home/jenkins/workspace/SparkPullRequestBuilder-K8s/resource-managers/kubernetes/integration-tests/src/test/scala/org/apache/spark/deploy/k8s/integrationtest/DecommissionSuite.scala:29: value WORKER_DECOMMISSION_ENABLED is not a member of object org.apache.spark.internal.config.Worker ). Looks like something else might have changed in master since when I started. Let me poke at that real quickly.

@holdenk
Copy link
Contributor Author

holdenk commented Aug 19, 2020

Looks like 3092527f7557b64ff9a5bedadfac8bb2f189a9b4 was committed and this broke the test suite. We really need to enable the K8s PRB in core.

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Test build #127658 has finished for PR 29479 at commit 8a88340.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32281/

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32281/

@holdenk
Copy link
Contributor Author

holdenk commented Aug 19, 2020

Token failure is probably unrelated, let’s see if it’s transient. Jenkins retest this please

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Test build #127661 has finished for PR 29479 at commit 8a88340.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32284/

@SparkQA
Copy link

SparkQA commented Aug 19, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/32284/

@holdenk holdenk changed the title [WIP][SPARK-32657][K8S] Update the log strings we check for in the decommission K8s [SPARK-32657][K8S] Update the log strings we check for in the decommission K8s Aug 19, 2020
@holdenk holdenk changed the title [SPARK-32657][K8S] Update the log strings we check for in the decommission K8s [SPARK-32657][K8S] Update the log strings we check for & imports in decommission K8s Aug 20, 2020
Copy link

@agrawaldevesh agrawaldevesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !.

@agrawaldevesh
Copy link

Lets get this in soon, so that it can unblock other PRs.

@dongjoon-hyun
Copy link
Member

Merged to master. Thank you, @holdenk and @agrawaldevesh .

@holdenk
Copy link
Contributor Author

holdenk commented Aug 20, 2020

Thanks @dongjoon-hyun for merging and calling my attention to the issue last night :)

holdenk added a commit to holdenk/spark that referenced this pull request Oct 27, 2020
…ecommission K8s

### What changes were proposed in this pull request?

Update the log strings to match the new log messages.

### Why are the changes needed?

Tests are failing

### Does this PR introduce _any_ user-facing change?

No, test only change.

### How was this patch tested?
WIP: Make sure the DecommissionSuite passes in Jenkins.

Closes apache#29479 from holdenk/SPARK-32657-Decommissioning-tests-update-log-string.

Authored-by: Holden Karau <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants