-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32393][SQL][TEST] Add tests for all the character types in PostgresIntegrationSuite #29394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… character arrays" This reverts commit 3d77131.
|
@dongjoon-hyun I checked manually that we've already supported the character types. So, I opened this PR to just add some trivial tests in the integration test. Could you check this? |
| """ARRAY['{"a": 1, "b": 2, "c": 3}']::jsonb[])""" | ||
| ) | ||
| .executeUpdate() | ||
| ).executeUpdate() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Updated this line to fix the wired format.
|
Oh, thanks, @maropu . |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
Since this is an integration test, I verified it manually.
PostgresIntegrationSuite:
- Type mapping for various types
- Basic write test
- Creating a table with shorts and floats
- SPARK-20557: column type TIMESTAMP with TIME ZONE and TIME with TIME ZONE should be recognized
- SPARK-22291: Conversion error when transforming array types of uuid, inet and cidr to StingType in PostgreSQL
- query JDBC option
- write byte as smallint
- character type tests
In addition to that, since the IT has a read test only, I verified that Apache Spark 3.0.0 can write to bpchar column successfully.
Thank you, @maropu .
Merged to master/3.0.
…tgresIntegrationSuite ### What changes were proposed in this pull request? This PR intends to add tests to check if all the character types in PostgreSQL supported. The document for character types in PostgreSQL: https://www.postgresql.org/docs/current/datatype-character.html Closes #29192. ### Why are the changes needed? For better test coverage. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Add tests. Closes #29394 from maropu/pr29192. Lead-authored-by: Takeshi Yamamuro <[email protected]> Co-authored-by: kujon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit b2c45f7) Signed-off-by: Dongjoon Hyun <[email protected]>
|
Ur, BTW, while updating JIRA, I found that the original JIRA example is different. |
|
Test build #127247 has finished for PR 29394 at commit
|
Ur, I see. I misunderstood it a bit. |
What changes were proposed in this pull request?
This PR intends to add tests to check if all the character types in PostgreSQL supported.
The document for character types in PostgreSQL: https://www.postgresql.org/docs/current/datatype-character.html
Closes #29192.
Why are the changes needed?
For better test coverage.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Add tests.