[SPARK-32538][CORE][TEST] Use local time zone for the timestamp logged in unit-tests.log #29356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #127090 has finished for PR 29356 at commit
|
maropu
reviewed
Aug 6, 2020
| // based on the local time zone depending on environments. | ||
| // The default time zone will be set to America/Los_Angeles later | ||
| // so this initialization is necessary here. | ||
| log |
Member
There was a problem hiding this comment.
hm, TimeZone.setDefault below doesn't an affect the already-instanciated logger?
Member
Author
There was a problem hiding this comment.
Seems so. DateFormat classes used in log4j uses Calendar, which is instantiated in the constructor with the default time zone at the time.
Member
There was a problem hiding this comment.
okay, if so, the change looks reasonable. cc: @srowen
maropu
changed the title
srowen
approved these changes
Aug 6, 2020
maropu
approved these changes
Aug 7, 2020
maropu
pushed a commit
that referenced
this pull request
Aug 7, 2020
…d in unit-tests.log ### What changes were proposed in this pull request? This PR lets the logger log timestamp based on local time zone during test. `SparkFunSuite` fixes the default time zone to America/Los_Angeles so the timestamp logged in unit-tests.log is also based on the fixed time zone. ### Why are the changes needed? It's confusable for developers whose time zone is not America/Los_Angeles. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Run existing tests and confirmed uint-tests.log. If your local time zone is America/Los_Angeles, you can test by setting the environment variable `TZ` like as follows. ``` $ TZ=Asia/Tokyo build/sbt "testOnly org.apache.spark.executor.ExecutorSuite" $ tail core/target/unit-tests.log ``` Closes #29356 from sarutak/fix-unit-test-log-timezone. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Takeshi Yamamuro <[email protected]> (cherry picked from commit 4e267f3) Signed-off-by: Takeshi Yamamuro <[email protected]>
Member
|
Thanks! Merged to master/branch-3.0. (NOTE: I manually checked this change could fix the issue) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR lets the logger log timestamp based on local time zone during test.
SparkFunSuitefixes the default time zone to America/Los_Angeles so the timestamp logged in unit-tests.log is also based on the fixed time zone.Why are the changes needed?
It's confusable for developers whose time zone is not America/Los_Angeles.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Run existing tests and confirmed uint-tests.log.
If your local time zone is America/Los_Angeles, you can test by setting the environment variable
TZlike as follows.