[SPARK-32509][SQL] Ignore unused DPP True Filter in Canonicalization #29318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakharjain09
force-pushed
the
SPARK-32509_df_reuse
branch
from
df019ce to
6cb0703
Compare
Contributor
Author
Contributor
|
ok to test |
cloud-fan
reviewed
Jul 31, 2020
| output.map(QueryPlan.normalizeExpressions(_, output)), | ||
| requiredSchema, | ||
| QueryPlan.normalizePredicates(partitionFilters, output), | ||
| QueryPlan.normalizePredicates(filterUnnecessaryPredicates(partitionFilters), output), |
Contributor
There was a problem hiding this comment.
Why does TrueLiteral affect canonicalize? TrueLiteral == TrueLiteral returns true, right?
Contributor
There was a problem hiding this comment.
Ah I got it. Maybe one side has DPP and one side not.
Can we filter out DynamicPruningExpression(Literal.TrueLiteral)? Then we don't need to change https://github.com/apache/spark/pull/29318/files#diff-6c00f36fadec282fce72ad39cfea51caL81 and make this PR less risky.
|
Test build #126890 has finished for PR 29318 at commit
|
prakharjain09
force-pushed
the
SPARK-32509_df_reuse
branch
from
f59fb49 to
b1f8ba8
Compare
Contributor
Author
|
@cloud-fan Thanks for the review. I have made the required changes. |
|
Test build #126918 has finished for PR 29318 at commit
|
|
Test build #126917 has finished for PR 29318 at commit
|
|
Test build #126920 has finished for PR 29318 at commit
|
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 3, 2020
### What changes were proposed in this pull request? This PR fixes issues relate to Canonicalization of FileSourceScanExec when it contains unused DPP Filter. ### Why are the changes needed? As part of PlanDynamicPruningFilter rule, the unused DPP Filter are simply replaced by `DynamicPruningExpression(TrueLiteral)` so that they can be avoided. But these unnecessary`DynamicPruningExpression(TrueLiteral)` partition filter inside the FileSourceScanExec affects the canonicalization of the node and so in many cases, this can prevent ReuseExchange from happening. This PR fixes this issue by ignoring the unused DPP filter in the `def doCanonicalize` method. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added UT. Closes #29318 from prakharjain09/SPARK-32509_df_reuse. Authored-by: Prakhar Jain <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit 7a09e71) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
@cloud-fan Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR fixes issues relate to Canonicalization of FileSourceScanExec when it contains unused DPP Filter.
Why are the changes needed?
As part of PlanDynamicPruningFilter rule, the unused DPP Filter are simply replaced by
DynamicPruningExpression(TrueLiteral)so that they can be avoided. But these unnecessaryDynamicPruningExpression(TrueLiteral)partition filter inside the FileSourceScanExec affects the canonicalization of the node and so in many cases, this can prevent ReuseExchange from happening.This PR fixes this issue by ignoring the unused DPP filter in the
def doCanonicalizemethod.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added UT.