[SPARK-32339][ML][DOC] Improve MLlib BLAS native acceleration docs #29139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
cc @srowen @viirya @zhengruifeng I scanned through. I think the doc is well written and the information is useful. Here are the screen capture: before change: after change: |
huaxingao
reviewed
Jul 17, 2020
srowen
requested changes
Jul 17, 2020
kiszk
reviewed
Jul 19, 2020
kiszk
reviewed
Jul 19, 2020
kiszk
reviewed
Jul 19, 2020
kiszk
reviewed
Jul 19, 2020
kiszk
reviewed
Jul 19, 2020
Contributor
Author
|
Fixed based on your comments. Thank you all! |
huaxingao
reviewed
Jul 20, 2020
srowen
requested changes
Jul 20, 2020
viirya
reviewed
Jul 21, 2020
Member
|
Jenkins test this please |
|
Test build #126549 has finished for PR 29139 at commit
|
huaxingao
reviewed
Jul 25, 2020
huaxingao
reviewed
Jul 25, 2020
huaxingao
reviewed
Jul 25, 2020
Contributor
|
LGTM. If nobody has further comments, I will merge this in both 3.0 and master. |
huaxingao
pushed a commit
that referenced
this pull request
Jul 28, 2020
### What changes were proposed in this pull request? Rewrite a clearer and complete BLAS native acceleration enabling guide. ### Why are the changes needed? The document of enabling BLAS native acceleration in ML guide (https://spark.apache.org/docs/latest/ml-guide.html#dependencies) is incomplete and unclear to the user. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? N/A Closes #29139 from xwu99/blas-doc. Lead-authored-by: Xiaochang Wu <[email protected]> Co-authored-by: Wu, Xiaochang <[email protected]> Signed-off-by: Huaxin Gao <[email protected]> (cherry picked from commit 44c868b) Signed-off-by: Huaxin Gao <[email protected]>
Contributor
|
Merged to 3.0/master. Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Rewrite a clearer and complete BLAS native acceleration enabling guide.
Why are the changes needed?
The document of enabling BLAS native acceleration in ML guide (https://spark.apache.org/docs/latest/ml-guide.html#dependencies) is incomplete and unclear to the user.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
N/A