-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-32274][SQL] Make SQL cache serialization pluggable #29067
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
4bf995f
Make SQL cache serialization pluggable
revans2 427fc68
Addressed review comments
revans2 0361237
Few more
revans2 641f28f
Merge branch 'master' into pluggable_cache_serializer
revans2 f989572
Fixed one set of tests
revans2 ad11a79
Fixed the other bug
revans2 cb29e47
Addressed review comments
revans2 c7c89bb
Merge branch 'master' into pluggable_cache_serializer
revans2 f0c7cfe
Addressed review comments
revans2 46f4021
Fixed some docs issues
revans2 10b0ce1
Fixed bad comment quoting, and added comments for reviews
revans2 38ca741
Added in abstraction for Columnar input
revans2 c2d00dc
Fixed formatting
revans2 082e883
Added in a test for columanr input and output to cache serializer
revans2 e58783e
Addressed review comments
revans2 05a430d
Merge branch 'master' into pluggable_cache_serializer
revans2 e0f5398
Fixed issue with columnar type for data generation
revans2 c9b1488
Addressed review comments
revans2 4ec28bb
Addressed more comments
revans2 7840a4c
Fixed docs
revans2 5723aa9
Addressed review comments
revans2 f8ca4af
Addressed review comments
revans2 ea762e5
Addressed review comments
revans2 ce66042
Merge branch 'master' into pluggable_cache_serializer
revans2 3f2f527
Addressed review comments
revans2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
343 changes: 343 additions & 0 deletions
343
sql/core/src/main/scala/org/apache/spark/sql/columnar/CachedBatchSerializer.scala
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this visibility change? For me, this is irrelevant to this PR. Can we remove this change from this PR? We had better make this change when it's inevitable.Oh, got it. Sorry, I was confused between twocolumnarpackages.