-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-31962][SQL] Provide modifiedAfter and modifiedBefore options when filtering from a batch-based file data source #28841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 134 commits
Commits
Show all changes
143 commits
Select commit
Hold shift + click to select a range
b1d6580
Added filesModifiedAfterDate parameter with method overloads
cchighman 145102e
Add first set of Unit Tests
cchighman 2b35de7
Updated to use a PathFilter visitor for consistency. Added support f…
cchighman 359cd42
Add more Unit Tests
cchighman 96ab0d8
Update Tests, Styles, an Docs
e03b9ec
Merge remote-tracking branch 'upstream/master'
ad05dbb
Update Styles
3d34b5f
Fix Scala Styles
f8eef35
Fix Tests
3f45acf
Added filesModifiedAfterDate parameter with method overloads
cchighman 0a69e73
Add first set of Unit Tests
cchighman 7a2cad0
Updated to use a PathFilter visitor for consistency. Added support f…
cchighman 8ee8e26
Add more Unit Tests
cchighman 45e8afe
Update Tests, Styles, an Docs
d9f7bea
Update Styles
8b62cad
Fix Scala Styles
2cb58e6
Fix Tests
0a97479
Merge branch 'master' of https://github.com/cchighman/spark
7906998
Merge remote-tracking branch 'upstream/master'
256cb1b
Fix the silly duplicate line
3929b84
Fix tests
cchighman 2b1c5dc
Fix spacing
cchighman 2126c85
Merge remote-tracking branch 'upstream/master'
cchighman 59f7787
Account for null
cchighman 918af78
Update Filter Name
cchighman 7110ca5
Merge remote-tracking branch 'upstream/master'
cchighman 58c35e6
Revert Previous Files
cchighman 032ca2f
Update Path Matching Logic
cchighman a754057
Update Examples
cchighman 0492b02
Docs and Styles
cchighman c9ad703
Unit Tests
cchighman 020973f
Merge branch 'master' of https://github.com/cchighman/spark
cchighman e815391
Fix Scala Style Tests
cchighman 86b5d6f
Final scala styling issues.
cchighman b4e0428
Python Lint and Docs
cchighman 4a80fdc
Silly missing line
cchighman d2f201b
Fix Doc Linting Issues
cchighman 5de1b44
Sphinx / Doc Build linting updates
cchighman 5121704
Merge remote-tracking branch 'upstream/master'
cchighman bbe63ec
Fix indentations and JIRA ticket name
cchighman 7ee667d
Fix newline at end of file
cchighman 4867cbc
Merge remote-tracking branch 'upstream/master'
cchighman d397fa0
Remove Streaming References
cchighman 150e77d
Revert streaming.py
cchighman 02631e9
Introduce abstraction layer for more efficient use of FileStatus
cchighman 772f5f5
Merge remote-tracking branch 'upstream/master'
cchighman eb8b3e6
Adjust asserts in unit test
cchighman fff7d66
Introduce Path Filter Strategies
cchighman b7263b3
Merge branch 'master' of https://github.com/cchighman/spark
cchighman 3dd6c9e
Update FileBasedDataSourceSuite.scala
cchighman 3b4acea
Unit Tests
cchighman 13439fb
Merge remote-tracking branch 'upstream/master'
cchighman 5126d9a
Merge branch 'master' into tz2
cchighman da78938
Merge Conflicts
cchighman 69c2393
Merge conflicts
cchighman b45f11e
Merge branch 'master' of https://github.com/cchighman/spark
cchighman 143a048
Path Filter Updates
cchighman de30391
Refinements
cchighman 56a0293
Update Sources
cchighman 23bbe52
Pulling from Master
cchighman 7cb912c
Merge from Master
cchighman 2efdb7a
Merge from Master
cchighman c2fba17
Fix newline
cchighman ac5227d
Remove new lines
cchighman 7a18b9e
Fix Linting
cchighman 17de795
Fix Linting
cchighman 853c432
Fix tests
cchighman 04de904
Final Linting Updates
cchighman e62568a
Removing empty python line:
cchighman 247b63b
Fix python styles
cchighman 8bb28eb
Reprocess python changes
cchighman 2ae67a3
Got run-tests working
cchighman ea9d484
Remove whitespace
cchighman 0e97f5e
Adjust formatting
cchighman b427e1c
Update example
cchighman 5d9a02a
Fix sneaking IDE auto correct
cchighman 724db1c
Merge remote-tracking branch 'upstream/master'
cchighman f849059
Add CaseInsensitiveMap Support
cchighman 944181c
Correct auto-correct ide lint
cchighman ebb7ede
Update Tests and Timezone
cchighman 5952fc2
Merge remote-tracking branch 'upstream/master'
cchighman d1ae21e
Adjust timezone condition
cchighman b7952a6
Add Locale.ROOT to test
cchighman 11e1109
Add more unit tests to validate change
cchighman 6e3e94f
Fix tests
cchighman b67c5ec
Change to lazy initialization
cchighman 48a4faf
Re-arrange tests
cchighman 37fbd8a
Explicitly set default sqlconf timezone
cchighman 03c2c3b
Change thresholdTime to a def
cchighman 46a8dbd
Remove flaky test
cchighman e305b40
remove whitespace
cchighman 05c6b89
retest
cchighman 98717dc
Whitespaces :)
cchighman 971c6ed
Resolve python conflict
cchighman 2e5a038
Revert "Resolve python conflict"
cchighman c59b4d6
Merge remote-tracking branch 'upstream/master'
cchighman 9979b96
Merge branch 'master' of https://github.com/cchighman/spark
cchighman 08c067a
Merge branch 'master' of https://github.com/cchighman/spark
cchighman 0f8a3c8
Revert "Merge remote-tracking branch 'upstream/master'"
cchighman 976c796
Revert changes
cchighman 54e4278
Revert "Revert "Merge remote-tracking branch 'upstream/master'""
cchighman 530295b
Restore conflicted source
cchighman bccc1b5
Merge remote-tracking branch 'upstream/master'
cchighman 37584c7
Resolve conflict
cchighman ca44781
Remove metals config
cchighman b925622
Reapply latest commit
cchighman 0f597f7
Path Filter Updates
cchighman e6f8928
Merge remote-tracking branch 'upstream/master'
cchighman 042c36e
Adjust Comments
cchighman 15a263c
Adjust Tests
cchighman b090639
Remove whitespace
cchighman cf9d2fa
Requested Updates
cchighman 5fc630e
Manual Style Corrections
cchighman c211e0e
Scala Style
cchighman ef37e2c
Remove un-necessary line changes
cchighman 09302dc
Remove space
cchighman 48438b5
Formatting
cchighman 50ebdfc
More Manual Formatting
cchighman 54dd3cf
Requested styling updates
cchighman 3ded6d0
Adjust test parameters
cchighman 0e069a7
Solidfy Tests
cchighman 04fe25c
minor fix
maropu 74b4d33
Merge pull request #2 from maropu/pr28841
cchighman 473f390
Update path filters source
cchighman 4329c8a
Commit updates
cchighman 1ee4af4
Fix method signature
cchighman fb5f767
Update Tests
cchighman 234e000
Merge remote-tracking branch 'upstream/master'
cchighman a7c6122
Merge remote-tracking branch 'upstream/master'
cchighman 263dd2a
Update Files
cchighman 3a99d90
Fine Tuning
cchighman 980f103
Refactor Tests
cchighman d57bf08
Formatting
cchighman 1c8384c
Scalafmt
cchighman 6de2346
Merge branch 'master' of http://github.com/cchighman/spark
cchighman 8dca5e5
Merge from Master
cchighman 4480ca7
Merge Corrections
cchighman 40c99dc
Carefully walk thru merge
cchighman 1d54fa5
Changes after run-tests
cchighman f88ef62
Reduce line length
cchighman aed5d30
trailing whitespace
cchighman 6b39e06
Correct merge issue
cchighman bf2a665
Correct silly oversight
cchighman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better not to change the order. I think such huge number of parameters end users will use named parameter almost every time, but just to be sure.