[MINOR][SQL] Add comments for filters values and return values of Row.get()/apply() #28300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@cloud-fan @HyukjinKwon Please, review the PR. |
Member
Author
|
The comment describes the default case when Java 8 date-time API is off, and it will be absolutely correct after the PR #28272 is merged. |
MaxGekk
changed the title
|
Test build #121623 has finished for PR 28300 at commit
|
|
Test build #121637 has finished for PR 28300 at commit
|
HyukjinKwon
approved these changes
Apr 23, 2020
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
To me, looks fine but let me leave it to @cloud-fan
Contributor
|
thanks, merging to master/3.0! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 23, 2020
….get()/apply() ### What changes were proposed in this pull request? - Document row field values of `DATE` and `TIMESTAMP` type returned by `Row.get()` and `Row.apply`. - Refer to `Row.get()` from the description of filter values ### Why are the changes needed? Reflect current behaviour of Row's method `apply()` and `get()` in comments to inform users about different return types that are depended on the SQL config settings `spark.sql.datetime.java8API.enabled`. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Run `$ ./dev/scalastyle` Closes #28300 from MaxGekk/doc-filter-date-time. Authored-by: Max Gekk <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit e7856a7) Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DATEandTIMESTAMPtype returned byRow.get()andRow.apply.Row.get()from the description of filter valuesWhy are the changes needed?
Reflect current behaviour of Row's method
apply()andget()in comments to inform users about different return types that are depended on the SQL config settingsspark.sql.datetime.java8API.enabled.Does this PR introduce any user-facing change?
No
How was this patch tested?
Run
$ ./dev/scalastyle