-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-31489][SPARK-31488][SQL] Translate date values of pushed down filters to java.sql.Date
#28272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[SPARK-31489][SPARK-31488][SQL] Translate date values of pushed down filters to java.sql.Date
#28272
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3dca84d
Translate filter values via translateFilterValues
MaxGekk 9ce9a34
Add useJava8DateTimeApi param
MaxGekk 32fb0ea
private[sql] -> private
MaxGekk d52fe37
Remove useJava8DateTimeApi from convertToScala()
MaxGekk ac0b27a
Revert "Remove useJava8DateTimeApi from convertToScala()"
MaxGekk ff2ca3f
Remove default value in convertToScala
MaxGekk 2a82a10
Dedup code in ParquetFilterSuite
MaxGekk d7b2ece
Dedup code in OrcFilterSuite
MaxGekk 2973dd7
Dedup code in OrcFilterSuite v1.2
MaxGekk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we're treating this as a temp fix for Spark 3.0?
Looks like ideally we should support Java 8 datetime instances for this interface as well when
spark.sql.datetime.java8API.enabledis enabled. It could cause more confusion. In addition, seems likespark.sql.datetime.java8API.enabledis disabled by default, too.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's problematic to let the java8 config also control the value type inside
Filter, as it can break existing DS v1 implementations. It's a bit unfortunate that we don't document clearly what the value type can be forFilter, but if we do, it's not user-friendly to say "the value type depends on xxx config". This just makes it harder to implement data source filter pushdown.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HyukjinKwon Taking into account #23811 (comment), the flag won't be enabled by default in the near future.