[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF#28070
Closed
Ngone51 wants to merge 3 commits into
Closed
[SPARK-31010][SQL][FOLLOW-UP] Add Java UDF suggestion in error message of untyped Scala UDF#28070Ngone51 wants to merge 3 commits into
Ngone51 wants to merge 3 commits into
Conversation
Ngone51
changed the title
Member
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Mar 30, 2020
| s"or set ${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with " + | ||
| s"caution." | ||
| "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) or Java UDF (e.g. " + | ||
| "`udf(new UDF1[String, Int] { override def call(s: String): Int = s.length() }, " + |
Contributor
There was a problem hiding this comment.
does Java UDF support scala Int?
cloud-fan
reviewed
Mar 30, 2020
| "You could use typed Scala UDF APIs (e.g. `udf((x: Int) => x)`) or Java UDF (e.g. " + | ||
| "`udf(new UDF1[String, Int] { override def call(s: String): Int = s.length() }, " + | ||
| "IntegerType)`) if input types are all non primitive to avoid this problem or set " + | ||
| "${SQLConf.LEGACY_ALLOW_UNTYPED_SCALA_UDF.key} to true and use this API with caution." |
Contributor
There was a problem hiding this comment.
now there are 3 workarounds, can we list them nicely?
"To get rid of this error, you could:\n" +
"1. use typed Scala UDF, e.g. ...\n" +
"2. use Java UDF, e.g. ..., if input types... \n" +
"3. set .... "
|
Test build #120582 has finished for PR 28070 at commit
|
cloud-fan
reviewed
Mar 30, 2020
| s"caution." | ||
| "To get rid of this error, you could:\n" + | ||
| "1. use typed Scala UDF APIs, e.g. `udf((x: Int) => x)`\n" + | ||
| "2. use Java UDF APIs, e.g. `udf(new UDF1[String, Int] { override def call(s: String): " + |
Contributor
There was a problem hiding this comment.
does Java UDF support scala Int?
Member
Author
There was a problem hiding this comment.
Yes, and I tested manually.
|
Test build #120590 has finished for PR 28070 at commit
|
Ngone51
changed the title
|
Test build #120635 has finished for PR 28070 at commit
|
Contributor
|
retest this please |
|
Test build #120647 has finished for PR 28070 at commit
|
cloud-fan
pushed a commit
that referenced
this pull request
Mar 31, 2020
…e of untyped Scala UDF ### What changes were proposed in this pull request? Added Java UDF suggestion in the in error message of untyped Scala UDF. ### Why are the changes needed? To help user migrate their use case from deprecate untyped Scala UDF to other supported UDF. ### Does this PR introduce any user-facing change? No. It haven't been released. ### How was this patch tested? Pass Jenkins. Closes #28070 from Ngone51/spark_31010. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com> (cherry picked from commit 590b9a0) Signed-off-by: Wenchen Fan <wenchen@databricks.com>
Contributor
|
thanks, merging to master/3.0! |
Member
Author
|
thanks! |
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…e of untyped Scala UDF ### What changes were proposed in this pull request? Added Java UDF suggestion in the in error message of untyped Scala UDF. ### Why are the changes needed? To help user migrate their use case from deprecate untyped Scala UDF to other supported UDF. ### Does this PR introduce any user-facing change? No. It haven't been released. ### How was this patch tested? Pass Jenkins. Closes apache#28070 from Ngone51/spark_31010. Authored-by: yi.wu <yi.wu@databricks.com> Signed-off-by: Wenchen Fan <wenchen@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added Java UDF suggestion in the in error message of untyped Scala UDF.
Why are the changes needed?
To help user migrate their use case from deprecate untyped Scala UDF to other supported UDF.
Does this PR introduce any user-facing change?
No. It haven't been released.
How was this patch tested?
Pass Jenkins.