Skip to content

Conversation

@fuwhu
Copy link
Contributor

@fuwhu fuwhu commented Feb 11, 2020

What changes were proposed in this pull request?

Add class document for PruneFileSourcePartitions and PruneHiveTablePartitions.

Why are the changes needed?

To describe these two classes.

Does this PR introduce any user-facing change?

no

How was this patch tested?

no


/**
* Prune the partitions of file source based table using partition filters. Currently, this rule
* is applied to [[HadoopFsRelation]] and [[DataSourceV2ScanRelation]].
Copy link
Contributor

@cloud-fan cloud-fan Feb 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DataSourceV2ScanRelation -> DataSourceV2ScanRelation with FileScan

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cloud-fan updated as :

DataSourceV2ScanRelation -> DataSourceV2ScanRelation with FileScan
HadoopFsRelation -> HadoopFsRelation with CatalogFileIndex

@cloud-fan cloud-fan changed the title Add class document for PruneFileSourcePartitions and PruneHiveTablePartitions [MINOR][DOC] Add class document for PruneFileSourcePartitions and PruneHiveTablePartitions Feb 11, 2020
@SparkQA
Copy link

SparkQA commented Feb 11, 2020

Test build #118194 has finished for PR 27535 at commit 23813ec.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Feb 11, 2020

Test build #118208 has finished for PR 27535 at commit 5274b1a.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor

retest this please

@SparkQA
Copy link

SparkQA commented Feb 11, 2020

Test build #118225 has finished for PR 27535 at commit 5274b1a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan cloud-fan closed this in f1d0dce Feb 11, 2020
@cloud-fan
Copy link
Contributor

thanks, merging to master/3.0!

cloud-fan pushed a commit that referenced this pull request Feb 11, 2020
…neHiveTablePartitions

### What changes were proposed in this pull request?
Add class document for PruneFileSourcePartitions and PruneHiveTablePartitions.

### Why are the changes needed?
To describe these two classes.

### Does this PR introduce any user-facing change?
no

### How was this patch tested?
no

Closes #27535 from fuwhu/SPARK-15616-FOLLOW-UP.

Authored-by: fuwhu <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit f1d0dce)
Signed-off-by: Wenchen Fan <[email protected]>
@fuwhu fuwhu deleted the SPARK-15616-FOLLOW-UP branch February 11, 2020 22:32
@fuwhu
Copy link
Contributor Author

fuwhu commented Feb 11, 2020

thank you all for help.

sjincho pushed a commit to sjincho/spark that referenced this pull request Apr 15, 2020
…neHiveTablePartitions

### What changes were proposed in this pull request?
Add class document for PruneFileSourcePartitions and PruneHiveTablePartitions.

### Why are the changes needed?
To describe these two classes.

### Does this PR introduce any user-facing change?
no

### How was this patch tested?
no

Closes apache#27535 from fuwhu/SPARK-15616-FOLLOW-UP.

Authored-by: fuwhu <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants