[SPARK-27946][SQL][FOLLOW-UP] Change doc and error message for SHOW CREATE TABLE #27505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @gatorsmile |
|
Test build #118089 has finished for PR 27505 at commit
|
Member
Author
|
retest this please |
|
Test build #118092 has finished for PR 27505 at commit
|
maropu
reviewed
Feb 9, 2020
| tableMetadata.unsupportedFeatures.map(" - " + _).mkString("\n") | ||
| tableMetadata.unsupportedFeatures.map(" - " + _).mkString("\n") + ". " + | ||
| s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " + | ||
| "to show Hive DDL instead." |
Member
There was a problem hiding this comment.
Do we have any test for this error case?
Member
Author
There was a problem hiding this comment.
Yea, test case hive partitioned view is not supported in HiveShowCreateTableSuite is for this error.
HyukjinKwon
approved these changes
Feb 10, 2020
Member
Author
|
I'm going to merge this to master and branch-3.0. |
viirya
added a commit
that referenced
this pull request
Feb 10, 2020
…REATE TABLE ### What changes were proposed in this pull request? This is a follow-up for #24938 to tweak error message and migration doc. ### Why are the changes needed? Making user know workaround if SHOW CREATE TABLE doesn't work for some Hive tables. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing unit tests. Closes #27505 from viirya/SPARK-27946-followup. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]> (cherry picked from commit acfdb46) Signed-off-by: Liang-Chi Hsieh <[email protected]>
sjincho
pushed a commit
to sjincho/spark
that referenced
this pull request
Apr 15, 2020
…REATE TABLE ### What changes were proposed in this pull request? This is a follow-up for apache#24938 to tweak error message and migration doc. ### Why are the changes needed? Making user know workaround if SHOW CREATE TABLE doesn't work for some Hive tables. ### Does this PR introduce any user-facing change? No ### How was this patch tested? Existing unit tests. Closes apache#27505 from viirya/SPARK-27946-followup. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up for #24938 to tweak error message and migration doc.
Why are the changes needed?
Making user know workaround if SHOW CREATE TABLE doesn't work for some Hive tables.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing unit tests.