-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-30651][SQL] Add detailed information for Aggregate operators in EXPLAIN FORMATTED #27368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 8 commits
2b48f4b
4ff35f9
426b953
65aea2a
2cc5daf
5e5d481
70cb2df
5b91b19
dd0988a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.execution.aggregate | ||
|
|
||
| import org.apache.spark.sql.catalyst.expressions.{Attribute, NamedExpression} | ||
| import org.apache.spark.sql.catalyst.expressions.aggregate.AggregateExpression | ||
| import org.apache.spark.sql.execution.{ExplainUtils, UnaryExecNode} | ||
|
|
||
| /** | ||
| * Holds common logic for aggregate operators | ||
| */ | ||
| abstract class BaseAggregateExec extends UnaryExecNode { | ||
| val groupingExpressions: Seq[NamedExpression] | ||
| val aggregateExpressions: Seq[AggregateExpression] | ||
| val aggregateAttributes: Seq[Attribute] | ||
| val resultExpressions: Seq[NamedExpression] | ||
|
||
|
|
||
| override def verboseStringWithOperatorId(): String = { | ||
| val inputString = child.output.mkString("[", ", ", "]") | ||
| val keyString = groupingExpressions.mkString("[", ", ", "]") | ||
| val functionString = aggregateExpressions.mkString("[", ", ", "]") | ||
| val aggregateAttributeString = aggregateAttributes.mkString("[", ", ", "]") | ||
| val resultString = resultExpressions.mkString("[", ", ", "]") | ||
| s""" | ||
| |(${ExplainUtils.getOpId(this)}) $nodeName ${ExplainUtils.getCodegenId(this)} | ||
| |Input: $inputString | ||
| |Keys: $keyString | ||
| |Functions: $functionString | ||
| |Aggregate Attributes: $aggregateAttributeString | ||
| |Results: $resultString | ||
| """.stripMargin | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we make it
trait?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, changed to
traitto make it consistent with other operators, e.g.HashJoinBaseLimitExec.