Skip to content

Conversation

@nchammas
Copy link
Contributor

@nchammas nchammas commented Jan 7, 2020

Follow-on to #26877.

What changes were proposed in this pull request?

This PR tweaks the stale PR message to clarify the procedure for reopening a PR after it has been marked as stale.

Why are the changes needed?

This change should clarify the reopening process for contributors.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

N/A

@nchammas
Copy link
Contributor Author

nchammas commented Jan 7, 2020

cc @dongjoon-hyun - Before merging this in, we may want to wait a bit to confirm that removing the Stale tag does indeed work as we expect.

@HyukjinKwon
Copy link
Member

I actually saw this and I think it works.

@SparkQA
Copy link

SparkQA commented Jan 7, 2020

Test build #116213 has finished for PR 27114 at commit a71dec6.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Jan 7, 2020

Test build #116225 has finished for PR 27114 at commit a71dec6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jan 7, 2020

Merged to master

@srowen srowen closed this in f399d65 Jan 7, 2020
@nchammas nchammas deleted the SPARK-30173-stale-tweaks branch January 7, 2020 17:40
@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 7, 2020

+1, late LGTM. Thank you, all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants