-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-29248][SQL] Add PhysicalWriteInfo with number of partitions #25990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 9 commits
Commits
Show all changes
46 commits
Select commit
Hold shift + click to select a range
c281373
[SPARK-29248][SQL] Pass in number of partitions to WriteBuilder
edrevo 903d863
move numpartitions to physicalbuildinfo
edrevo c6b95f5
Merge branch 'master' of https://github.com/apache/spark into add-par…
edrevo 30c8800
fixes
edrevo 15096b2
fixes
edrevo 389afee
lint fixes
edrevo 4f10e54
[SPARK-29655][SQL] Read bucketed tables obeys spark.sql.shuffle.parti…
wangyum ca4e894
PR feedback
edrevo 16e3c4a
more pr feedback
edrevo ee4784b
[SPARK-26499][SQL][FOLLOW-UP] Replace `update` with `setByte` for Byt…
maropu 1521889
[SPARK-29902][DOC][MINOR] Add listener event queue capacity configura…
shahidki31 848bdfa
[SPARK-29829][SQL] SHOW TABLE EXTENDED should do multi-catalog resolu…
planga82 c0507e0
[SPARK-29833][YARN] Add FileNotFoundException check for spark.yarn.jars
ulysses-you 7720781
[SPARK-29127][SQL][PYTHON] Add a clue for Python related version info…
HyukjinKwon 16e7195
[SPARK-29834][SQL] DESC DATABASE should look up catalog like v2 commands
fuwhu 6d6b233
[SPARK-29343][SQL][FOLLOW-UP] Remove floating-point Sum/Average/Centr…
maropu 1112fc6
[SPARK-29867][ML][PYTHON] Add __repr__ in Python ML Models
huaxingao f77c10d
[SPARK-29923][SQL][TESTS] Set io.netty.tryReflectionSetAccessible for…
dongjoon-hyun 40ea4a1
[SPARK-29807][SQL] Rename "spark.sql.ansi.enabled" to "spark.sql.dial…
xuanyuanking d0470d6
[MINOR][TESTS] Ignore GitHub Action and AppVeyor file changes in testing
dongjoon-hyun 5336473
[SPARK-29476][WEBUI] add tooltip for Thread
PavithraRamachandran e88267c
[SPARK-29928][SQL][TESTS] Check parsing timestamps up to microsecond …
MaxGekk cc12cf6
[SPARK-29378][R] Upgrade SparkR to use Arrow 0.15 API
dongjoon-hyun 388a737
[SPARK-29858][SQL] ALTER DATABASE (SET DBPROPERTIES) should look up c…
fuwhu a9959be
[SPARK-29456][WEBUI] Improve tooltip for Session Statistics Table col…
PavithraRamachandran e1fc38b
[SPARK-29932][R][TESTS] lint-r should do non-zero exit in case of errors
dongjoon-hyun 5eb8973
[SPARK-29930][SQL] Remove SQL configs declared to be removed in Spark…
MaxGekk c5f644c
[SPARK-16872][ML][PYSPARK] Impl Gaussian Naive Bayes Classifier
zhengruifeng d83cacf
[SPARK-29907][SQL] Move DELETE/UPDATE/MERGE relative rules to dmlStat…
f280c6a
[SPARK-29378][R][FOLLOW-UP] Remove manual installation of Arrow depen…
HyukjinKwon 42f8f79
[SPARK-29936][R] Fix SparkR lint errors and add lint-r GitHub Action
dongjoon-hyun 9ff8ac7
javadoc fixes
edrevo ee3bd6d
[SPARK-25694][SQL] Add a config for `URL.setURLStreamHandlerFactory`
jiangzho 7391237
[SPARK-29020][SQL] Improving array_sort behaviour
5cebe58
[SPARK-29783][SQL] Support SQL Standard/ISO_8601 output style for int…
yaooqinn 50f6d93
[SPARK-29870][SQL] Unify the logic of multi-units interval string to …
yaooqinn c32e228
[SPARK-29859][SQL] ALTER DATABASE (SET LOCATION) should look up catal…
fuwhu ae6b711
[SPARK-29941][SQL] Add ansi type aliases for char and decimal
yaooqinn ea010a2
[SPARK-29873][SQL][TEST][FOLLOWUP] set operations should not escape w…
yaooqinn 9514b82
[SPARK-29777][SPARKR] SparkR::cleanClosure aggressively removes a fun…
falaki 8469614
[SPARK-25694][SQL][FOLLOW-UP] Move 'spark.sql.defaultUrlStreamHandler…
HyukjinKwon 882f54b
[SPARK-29870][SQL][FOLLOW-UP] Keep CalendarInterval's toString
HyukjinKwon 28a502c
[SPARK-28527][FOLLOW-UP][SQL][TEST] Add guides for ThriftServerQueryT…
wangyum a834dba
Revert "[SPARK-29644][SQL] Corrected ShortType and ByteType mapping t…
shivsood 3d45779
[SPARK-29728][SQL] Datasource V2: Support ALTER TABLE RENAME TO
imback82 118d81f
[SPARK-29248][SQL] Add PhysicalWriteInfo with number of partitions
edrevo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
40 changes: 40 additions & 0 deletions
40
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/LogicalWriteInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector.write; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
| import org.apache.spark.sql.types.StructType; | ||
|
|
||
| /** | ||
| * This interface contains write information that data sources can use when generating a | ||
| * {@link WriteBuilder}. | ||
| */ | ||
| @Evolving | ||
| public interface LogicalWriteInfo { | ||
| /** | ||
| * `queryId` is a unique string of the query. It's possible that there are many queries | ||
| * running at the same time, or a query is restarted and resumed. {@link BatchWrite} can use | ||
| * this id to identify the query. | ||
| */ | ||
| String queryId(); | ||
|
|
||
| /** | ||
| * the schema of the input data from Spark to data source. | ||
| */ | ||
| StructType schema(); | ||
| } | ||
33 changes: 33 additions & 0 deletions
33
sql/catalyst/src/main/java/org/apache/spark/sql/connector/write/PhysicalWriteInfo.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector.write; | ||
|
|
||
| import org.apache.spark.annotation.Evolving; | ||
| import org.apache.spark.sql.connector.write.streaming.StreamingDataWriterFactory; | ||
|
|
||
| /** | ||
| * This interface contains physical write information that data sources can use when | ||
| * generating a {@link DataWriterFactory} or a {@link StreamingDataWriterFactory}. | ||
| */ | ||
| @Evolving | ||
| public interface PhysicalWriteInfo { | ||
| /** | ||
| * The number of partitions of the input data that is going to be written. | ||
| */ | ||
| int numPartitions(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
sql/catalyst/src/main/scala/org/apache/spark/sql/connector/write/LogicalWriteInfoImpl.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector.write | ||
|
|
||
| import org.apache.spark.sql.types.StructType | ||
|
|
||
| private[sql] case class LogicalWriteInfoImpl( | ||
| queryId: String, | ||
| schema: StructType) extends LogicalWriteInfo |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are write options not part of
LogicalWriteInfo?