Skip to content

[SPARK-29104][CORE][TESTS] Fix PipedRDDSuite to use eventually to check thread termination #25808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-29104][CORE][TESTS] Fix PipedRDDSuite to use eventually to check thread termination #25808

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e9f99
[SPARK-29104][CORE][TESTS] Fix PipedRDDSuite to wait messages before …
dongjoon-hyun Sep 16, 2019
918cbd7
Use eventually.
dongjoon-hyun Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions core/src/test/scala/org/apache/spark/rdd/PipedRDDSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ class PipedRDDSuite extends SparkFunSuite with SharedSparkContext {
val result = piped.mapPartitions(_ => Array.emptyIntArray.iterator)

assert(result.collect().length === 0)
sc.listenerBus.waitUntilEmpty(10000)
Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Sep 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the fix and the remaining is typo fix from err to in.


// collect stderr writer threads
val stderrWriterThread = Thread.getAllStackTraces.keySet().asScala
// collect stdin writer threads
val stdinWriterThread = Thread.getAllStackTraces.keySet().asScala
.find { _.getName.startsWith(PipedRDD.STDIN_WRITER_THREAD_PREFIX) }

assert(stderrWriterThread.isEmpty)
assert(stdinWriterThread.isEmpty)
}

test("advanced pipe") {
Expand Down