Skip to content

[SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. #25458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
younggyuchun wants to merge 8 commits into from
Closed

[SPARK-27931][SQL] Accept "true", "yes", "1", "false", "no", "0", and unique prefixes as input and trim input for the boolean data type. #25458

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7d61642
[SPARK-27931][SQL] Accept 'on' and 'off' as input and trim input for …
Aug 15, 2019
933fe86
[SPARK-27931][SQL] Unique prefixes of strings are also accepted for t…
Aug 16, 2019
a5aec9f
Trim string whitespace so it should be true
Aug 16, 2019
9e9aac3
Generated spark golden files.
Aug 16, 2019
dacd46b
add a comment: "true", "yes", "1", "false", "no", "0", and unique pre…
Aug 27, 2019
abe9a84
[SPARK-27931][SQL] add a "FAlse" test case and remove the redundant s…
Aug 30, 2019
2ea551c
[SPARK-27931][SQL] add a negative test case for "o"
Aug 30, 2019
b787483
removed "[SPARK-27931] Trim the string when cast string type to boole…
Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/StringUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,15 @@ object StringUtils extends Logging {
"(?s)" + out.result() // (?s) enables dotall mode, causing "." to match new lines
}

private[this] val trueStrings = Set("t", "true", "y", "yes", "1").map(UTF8String.fromString)
private[this] val falseStrings = Set("f", "false", "n", "no", "0").map(UTF8String.fromString)
private[this] val trueStrings =
Set("t", "true", "y", "yes", "1", "on").map(UTF8String.fromString)

private[this] val falseStrings =
Set("f", "false", "n", "no", "0", "off").map(UTF8String.fromString)
Copy link
Member

@wangyum wangyum Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems only PostgreSQL accepts on and off?

Copy link
Author

@younggyuchun younggyuchun Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I guess so. Do you know other common string representattion used in other databases?

Copy link
Member

@wangyum wangyum Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But PostgreSQL also acceptsof, tru, fals, ...:

postgres=# select cast('of' as boolean), cast('tru' as boolean), cast('fals' as boolean);
 bool | bool | bool
------+------+------
 f    | t    | f
(1 row)

postgres/postgres@9729c93

Copy link
Author

@younggyuchun younggyuchun Aug 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay. Let me add that too. Thank you


// scalastyle:off caselocale
def isTrueString(s: UTF8String): Boolean = trueStrings.contains(s.toLowerCase)
def isFalseString(s: UTF8String): Boolean = falseStrings.contains(s.toLowerCase)
def isTrueString(s: UTF8String): Boolean = trueStrings.contains(s.toLowerCase.trim())
def isFalseString(s: UTF8String): Boolean = falseStrings.contains(s.toLowerCase.trim())
// scalastyle:on caselocale

/**
Expand Down
4 changes: 4 additions & 0 deletions sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -825,13 +825,17 @@ class CastSuite extends SparkFunSuite with ExpressionEvalHelper {
checkCast("y", true)
checkCast("yes", true)
checkCast("1", true)
checkCast("on", true)
checkCast(" true ", true)

checkCast("f", false)
checkCast("false", false)
checkCast("FAlsE", false)
checkCast("n", false)
checkCast("no", false)
checkCast("0", false)
checkCast("off", false)
checkCast(" off ", false)

checkEvaluation(cast("abc", BooleanType), null)
checkEvaluation(cast("", BooleanType), null)
Expand Down