Skip to content

Conversation

@wangyum
Copy link
Member

@wangyum wangyum commented Aug 13, 2019

What changes were proposed in this pull request?

Utilities.addToClassPath has been changed since HIVE-22096, but we use it to add plugin jars:

val auxJars = HiveConf.getVar(conf, HiveConf.ConfVars.HIVEAUXJARS)
if (StringUtils.isNotBlank(auxJars)) {
loader = Utilities.addToClassPath(loader, StringUtils.split(auxJars, ","))
}

This PR add test for spark-sql adding plugin jars.

How was this patch tested?

N/A

@SparkQA
Copy link

SparkQA commented Aug 13, 2019

Test build #109044 has finished for PR 25435 at commit 838da98.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.
Thank you, @wangyum .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-28714][SQL][TEST] Add test for spark-sql support hive.aux.jars.path [SPARK-28714][SQL][TEST] Add hive.aux.jars.path test for spark-sql shell Aug 13, 2019
@wangyum wangyum deleted the SPARK-28714 branch August 13, 2019 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants