Skip to content

[SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ #25429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wangyum wants to merge 2 commits into from
Closed

[SPARK-28708][SQL] IsolatedClientLoader will not load hive classes from application jars on JDK9+ #25429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cab0590
Fix classLoader on JDK9+
wangyum Aug 13, 2019
103e7a1
Remove the word 'above' in the comment
wangyum Aug 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,18 +338,20 @@ private[spark] object HiveUtils extends Logging {
}

val classLoader = Utils.getContextOrSparkClassLoader
val jars = allJars(classLoader)
if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
val jars: Array[URL] = if (SystemUtils.isJavaVersionAtLeast(JavaVersion.JAVA_9)) {
// Do nothing. The system classloader is no longer a URLClassLoader in Java 9,
// so it won't match the case in allJars above. It no longer exposes URLs of
// so it won't match the case in allJars. It no longer exposes URLs of
// the system classpath
Array.empty[URL]
} else {
val loadedJars = allJars(classLoader)
// Verify at least one jar was found
if (jars.length == 0) {
if (loadedJars.length == 0) {
throw new IllegalArgumentException(
"Unable to locate hive jars to connect to metastore. " +
s"Please set ${HIVE_METASTORE_JARS.key}.")
}
loadedJars
}

logInfo(
Expand Down