[SPARK-28695][SS] Use CaseInsensitiveMap in KafkaSourceProvider to make source param handling more robust #25418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
SPARK-28163 fixed a bug and during the analysis we've concluded it would be more robust to use
CaseInsensitiveMapinside Kafka source. This case less lower/upper case problem would rise in the future.Please note this PR doesn't intend to solve any kind of actual problem but finish the concept added in SPARK-28163 (in a fix PR I didn't want to add too invasive changes). In this PR I've changed
Map[String, String]toCaseInsensitiveMap[String]to enforce the usage. These are the main use-cases:contains=>CaseInsensitiveMapsolves itget...=>CaseInsensitiveMapsolves itfilter=> keys must be converted to lowercase because there is no guarantee that the incoming map has such key setfind=> keys must be converted to lowercase because there is no guarantee that the incoming map has such key setHow was this patch tested?
Existing unit tests.