-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28685][SQL][TEST] Test HMS 2.0.0+ in VersionsSuite/HiveClientSuites on JDK 11 #25405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Note that, this pr will not fix |
|
Test build #108919 has finished for PR 25405 at commit
|
|
Retest this please. |
|
Thank you @dongjoon-hyun |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank YOU, @wangyum !
+1, LGTM. Merged to master.
(This passed Jenkins with hadoop-2.7 already and the hadoop-3.2 Jenkins run also passed all Java tests).
|
Test build #108925 has finished for PR 25405 at commit
|
|
cc @srowen , @gatorsmile , @cloud-fan since this PR removed the test coverage for old HMS at JDK11. If there is a way to support JDK11 with old HMS libraries, we can re-enable this later. |
|
That sounds good to me. |
|
@shaneknapp Could we support adding |
|
@shaneknapp .. actually, adding For some context as FYI, for JDK 11 support, I asked feasibility about Hive 2.3.6 release at this Hive dev thread. Thankfully, seems positive. @wangyum quickly started worked on that and @alanfgates (from Hive) is actively cooperative - thanks again. Therefore, two communities are cooperating at SPARK-28684 and HIVE-22096 . It might be much easier if we can test JDK 11 in PR builder in Spark side. |
it'll be easy to add the java11 check in i'll start hacking on it now while i wait for the jira to pop up. |
i created the jira: https://issues.apache.org/jira/browse/SPARK-28701 pull request coming now. |
… for pull request builds ## What changes were proposed in this pull request? we need to add the ability to test PRBs against java11. see comments here: #25405 ## How was this patch tested? the build system will test this. Closes #25423 from shaneknapp/spark-prb-java11. Authored-by: shane knapp <[email protected]> Signed-off-by: HyukjinKwon <[email protected]>
What changes were proposed in this pull request?
It seems Datanucleus 3.x can not support JDK 11:
Hive upgrade Datanucleus to 4.x from Hive 2.0(HIVE-6113). This PR makes it skip
0.12,0.13,0.14,1.0,1.1and1.2when testing with JDK 11.Note that, this pr will not fix sql read hive materialized view. It's another issue:
How was this patch tested?
manual tests: