[SPARK-28579][ML] MaxAbsScaler avoids conversion to breeze.vector #25311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test build #108455 has finished for PR 25311 at commit
|
srowen
reviewed
Jul 31, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Looking OK. Are there more transformers that can benefit from this type of change?
Contributor
Author
|
@srowen I had scan other feature algs, and can not to find any similar place. |
srowen
approved these changes
Aug 1, 2019
Member
|
Merged to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
avoid
.ml.vector => .breeze.vectorconversion inMaxAbsScaler,and reuse the transformation method in
StandardScalerModel, which can deal with dense & sparse vector separately.How was this patch tested?
existing suites