-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28578][INFRA] Improve Github pull request template #25310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,39 @@ | ||
| ## What changes were proposed in this pull request? | ||
| <!-- | ||
| Thanks for sending a pull request! Here are some tips for you: | ||
| 1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html | ||
| 2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html | ||
| 3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'. | ||
| 4. Update your PR description whenever it is needed. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 5. Provide a concise example to reproduce the issue if possible for a faster review. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| --> | ||
|
|
||
| (Please fill in changes proposed in this fix) | ||
| ### What changes were proposed in this pull request? | ||
HyukjinKwon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <!-- | ||
| Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. | ||
| Therefore, if possible, please consider write some useful notes for better and faster reviews in your PR. See the examples below. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers. | ||
| 2. If you fix some SQL features, you can provide some references of other DBMSes. | ||
| 3. If there is a design documentation, please leave the link. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 4. If there is a discussion in the mailing list, please leave the link. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| --> | ||
|
|
||
| ## How was this patch tested? | ||
|
|
||
| (Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests) | ||
| (If this patch involves UI changes, please attach a screenshot; otherwise, remove this) | ||
| ### Why are the changes needed? | ||
HyukjinKwon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <!-- | ||
| Please clarify why the changes are needed. For instance, | ||
| 1. If you propose a new API, clarify the usecase for a new API. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| 2. If you fixes a bug, you can calrify why it is a bug. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| --> | ||
|
|
||
| Please review https://spark.apache.org/contributing.html before opening a pull request. | ||
| ### Does this PR introduce any user-facing change? | ||
HyukjinKwon marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <!-- | ||
| If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behaviour difference if possible. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| If no, write 'No'. | ||
| --> | ||
|
|
||
|
|
||
| ### How was this patch tested? | ||
| <!-- | ||
| If some tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check through, and descendants can verify in the future. | ||
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
HyukjinKwon marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| --> | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.