[SPARK-28464][Doc][SS] Document Kafka source minPartitions option #25219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
| <tr> | ||
| <td>minPartitions</td> | ||
| <td>int</td> | ||
| <td>0 (disabled)</td> |
Member
There was a problem hiding this comment.
Thank you for your first contribution, @arunpandianp .
However, this is wrong because this will mislead the users to try to set 0 and face IllegalArgumentException.
Technically, the default value is None. Just leave this line as a blank like <td></td>.
Author
|
@dongjoon-hyun thanks for checking, changed it to |
|
Test build #107962 has finished for PR 25219 at commit
|
| <td></td> | ||
| <td>streaming and batch</td> | ||
| <td>Minimum number of partitions to read from Kafka. | ||
| You can configure Spark to use an arbitrary minimum of partitions to read from Kafka using the minPartitions option. |
Member
There was a problem hiding this comment.
Let's remove this line because we don't allow arbitrary number.
| <td>streaming and batch</td> | ||
| <td>Minimum number of partitions to read from Kafka. | ||
| You can configure Spark to use an arbitrary minimum of partitions to read from Kafka using the minPartitions option. | ||
| Normally Spark has a 1-1 mapping of Kafka TopicPartitions to Spark partitions consuming from Kafka. |
Member
There was a problem hiding this comment.
Normally -> By default, ?
| If you set the minPartitions option to a value greater than your Kafka TopicPartitions, | ||
| Spark will divvy up large Kafka partitions to smaller pieces. | ||
| This option can be set at times of peak loads, data skew, and as your stream is falling behind to increase processing rate. | ||
| It comes at a cost of initializing Kafka consumers at each trigger, which may impact performance if you use SSL when connecting to Kafka.</td> |
Member
There was a problem hiding this comment.
Let's remove line 401~402, too.
|
Test build #107963 has finished for PR 25219 at commit
|
|
Test build #107964 has finished for PR 25219 at commit
|
Author
|
@dongjoon-hyun pushed suggested changes. |
dongjoon-hyun
approved these changes
Jul 21, 2019
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @arunpandianp .
Merged to master/branch-2.4.
| <td>Minimum number of partitions to read from Kafka. | ||
| By default, Spark has a 1-1 mapping of Kafka TopicPartitions to Spark partitions consuming from Kafka. | ||
| If you set the minPartitions option to a value greater than your Kafka TopicPartitions, | ||
| Spark will divvy up large Kafka partitions to smaller pieces. |
Member
There was a problem hiding this comment.
</td> is missed. I'll fix that during merging.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 21, 2019
Adding doc for the kafka source minPartitions option to "Structured Streaming + Kafka Integration Guide" The text is based on the content in https://docs.databricks.com/spark/latest/structured-streaming/kafka.html#configuration Closes #25219 from arunpandianp/SPARK-28464. Authored-by: Arun Pandian <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a0a58cf) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Welcome to the Apache Spark community, @arunpandianp . |
yiheng
pushed a commit
to yiheng/spark
that referenced
this pull request
Jul 24, 2019
Adding doc for the kafka source minPartitions option to "Structured Streaming + Kafka Integration Guide" The text is based on the content in https://docs.databricks.com/spark/latest/structured-streaming/kafka.html#configuration Closes apache#25219 from arunpandianp/SPARK-28464. Authored-by: Arun Pandian <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
rluta
pushed a commit
to rluta/spark
that referenced
this pull request
Sep 17, 2019
Adding doc for the kafka source minPartitions option to "Structured Streaming + Kafka Integration Guide" The text is based on the content in https://docs.databricks.com/spark/latest/structured-streaming/kafka.html#configuration Closes apache#25219 from arunpandianp/SPARK-28464. Authored-by: Arun Pandian <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a0a58cf) Signed-off-by: Dongjoon Hyun <[email protected]>
kai-chi
pushed a commit
to kai-chi/spark
that referenced
this pull request
Sep 26, 2019
Adding doc for the kafka source minPartitions option to "Structured Streaming + Kafka Integration Guide" The text is based on the content in https://docs.databricks.com/spark/latest/structured-streaming/kafka.html#configuration Closes apache#25219 from arunpandianp/SPARK-28464. Authored-by: Arun Pandian <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a0a58cf) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding doc for the kafka source minPartitions option to "Structured Streaming + Kafka Integration Guide"