Skip to content

[SPARK-28201][SQL][TEST][FOLLOWUP] Fix Integration test suite according to the new exception message #25165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 2 commits into from
Closed

[SPARK-28201][SQL][TEST][FOLLOWUP] Fix Integration test suite according to the new exception message #25165

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0de5843
[SPARK-28201][SQL][TEST][FOLLOWUP] Update Integration test suite acco…
dongjoon-hyun Jul 15, 2019
a822c71
Address comments
dongjoon-hyun Jul 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...r-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,8 +376,8 @@ class OracleIntegrationSuite extends DockerJDBCIntegrationSuite with SharedSQLCo
val e = intercept[org.apache.spark.SparkException] {
spark.read.jdbc(jdbcUrl, "tableWithCustomSchema", new Properties()).collect()
}
assert(e.getMessage.contains(
"requirement failed: Decimal precision 39 exceeds max precision 38"))
assert(e.getCause().isInstanceOf[ArithmeticException])
assert(e.getMessage.contains("Decimal precision 39 exceeds max precision 38"))
Copy link
Contributor

@mgaido91 mgaido91 Jul 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as a very nit, I'd rather check the exception type, which I think is more important than the exact message. Now we should be coherent in the whole codebase and always throw an ArithmeticException, while previously we were sometimes throwing RuntimeException or others for the same case.

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jul 15, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review, @mgaido91 .

Sure, of course, we can check the underlying exception type by e.getCause from SparkException additionally. I'll add that.

BTW, message checking is a more fine-grained verification. As you know, ArithmeticException and ParseException are not specific. For example, ArithmeticException can be caused by divide by zero. We should check the error message always.


// custom schema can read data
val props = new Properties()
Expand Down