[SPARK-28306][SQL][FOLLOWUP] Fix NormalizeFloatingNumbers rule idempotence for equi-join with <=> predicates#25126
Closed
yeshengm wants to merge 4 commits into
Closed
[SPARK-28306][SQL][FOLLOWUP] Fix NormalizeFloatingNumbers rule idempotence for equi-join with <=> predicates#25126yeshengm wants to merge 4 commits into
<=> predicates#25126yeshengm wants to merge 4 commits into
Conversation
maropu
approved these changes
Jul 11, 2019
gatorsmile
reviewed
Jul 11, 2019
Member
There was a problem hiding this comment.
Just replace it by Equality?
Member
|
@yeshengm . Please use a proper PR title according to the PR content. |
yeshengm
changed the title
<=> predicates
|
Test build #107559 has finished for PR 25126 at commit
|
|
Test build #107567 has finished for PR 25126 at commit
|
Member
|
Could you fix the following UT failure, @yeshengm ?
|
|
Test build #107610 has finished for PR 25126 at commit
|
|
Test build #107614 has finished for PR 25126 at commit
|
gatorsmile
reviewed
Jul 15, 2019
gatorsmile
left a comment
gatorsmile
left a comment
Member
There was a problem hiding this comment.
LGTM
Thanks! Merged to master.
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jul 18, 2019
…tence for equi-join with `<=>` predicates ## What changes were proposed in this pull request? Idempotence of the `NormalizeFloatingNumbers` rule was broken due to the implementation of `ExtractEquiJoinKeys`. There is no reason that we don't remove `EqualNullSafe` join keys from an equi-join's `otherPredicates`. ## How was this patch tested? A new UT. Closes apache#25126 from yeshengm/spark-28306. Authored-by: Yesheng Ma <kimi.ysma@gmail.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
j-baker
pushed a commit
to palantir/spark
that referenced
this pull request
Jan 28, 2020
…tence for equi-join with `<=>` predicates ## What changes were proposed in this pull request? Idempotence of the `NormalizeFloatingNumbers` rule was broken due to the implementation of `ExtractEquiJoinKeys`. There is no reason that we don't remove `EqualNullSafe` join keys from an equi-join's `otherPredicates`. ## How was this patch tested? A new UT. Closes apache#25126 from yeshengm/spark-28306. Authored-by: Yesheng Ma <kimi.ysma@gmail.com> Signed-off-by: gatorsmile <gatorsmile@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Idempotence of the
NormalizeFloatingNumbersrule was broken due to the implementation ofExtractEquiJoinKeys. There is no reason that we don't removeEqualNullSafejoin keys from an equi-join'sotherPredicates.How was this patch tested?
A new UT.