-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-28309][R][INFRA] Fix AppVeyor to run SparkR tests by avoiding to use devtools for testthat #25081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you so much for working on this, @HyukjinKwon ! |
|
@felixcheung .. I think it's time to update our SparkR tests to use higher versions of testthat soon.. |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM.
|
I am merging this. |
|
Merged to master. Let me merge this one only to master for now. It's rather a temp fix. Thanks, @dongjoon-hyun |
|
Test build #107380 has finished for PR 25081 at commit
|
|
thanks! definitely, it's a bit dated. I recalled trying to update it but the "new" testthat had changes to a method that we called into and so it broke that and I couldn't get it to work... |
|
Yea .. I couldn't get it to work too .. Maybe it might need a bigger change to adopt to newer testthat hm hm .. |
|
FYI, this readme no longer works either Running R Tests R -e "install.packages(c('knitr', 'rmarkdown', 'devtools', 'e1071', 'survival'), repos='http://cran.us.r-project.org')" |
|
Can you file a JIRA with showing the console output? |
What changes were proposed in this pull request?
Looks
devtools2.1.0 is released and then our AppVeyor users the latest one.The problem is, they added
testthat2.1.1+ as its dependency - https://github.com/r-lib/devtools/blob/master/DESCRIPTION#L35Usually it should remove and reinstall it properly when we install other packages; however, seems it's being failed in AppVeyor due to the previous installation for an unknown reason.
See https://ci.appveyor.com/project/ApacheSoftwareFoundation/spark/builds/25818746
Our SparkR testbed requires
testthat1.0.2 at most for the current status anddevtoolswas installed at SPARK-22817 to pin thetestthatversion to 1.0.2Therefore, this PR works around the current issue by directly installing from the archive instead, and don't use
devtools.How was this patch tested?
AppVeyor will test.