Skip to content

[SPARK-28261][CORE] Fix client reuse test #25075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaborgsomogyi wants to merge 1 commit into from
Closed

[SPARK-28261][CORE] Fix client reuse test #25075

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...on/network-common/src/test/java/org/apache/spark/network/TransportClientFactorySuite.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ private void testClientReuse(int maxConnections, boolean concurrent)
}

Assert.assertEquals(0, failed.get());
Assert.assertEquals(clients.size(), maxConnections);
Assert.assertTrue(clients.size() <= maxConnections);
Copy link
Member

@dongjoon-hyun dongjoon-hyun Jul 8, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for the investigation and this PR, @gaborgsomogyi .
Could you update the PR description if we have a previous Jenkins test failure for this, please?

Copy link
Member

@srowen srowen Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose there's no way to ask it to not return a cached instance?
This seems to be testing that they're all different, but, that doesn't seem to be the current behavior, nor is it necessarily desirable. So, OK.


for (TransportClient client : clients) {
client.close();
Expand Down