Skip to content
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
126 changes: 126 additions & 0 deletions sql/core/src/test/resources/sql-tests/inputs/pgSQL/int2.sql
Original file line number Diff line number Diff line change
@@ -0,0 +1,126 @@
--
-- Portions Copyright (c) 1996-2019, PostgreSQL Global Development Group
--
--
-- INT2
-- https://github.com/postgres/postgres/blob/REL_12_BETA1/src/test/regress/sql/int2.sql

CREATE TABLE INT2_TBL(f1 smallint) USING parquet;

-- [SPARK-28023] Trim the string when cast string type to other types
INSERT INTO INT2_TBL VALUES (trim('0 '));

INSERT INTO INT2_TBL VALUES (trim(' 1234 '));

INSERT INTO INT2_TBL VALUES (trim(' -1234'));

-- [SPARK-27923] Invalid input syntax for type short throws exception at PostgreSQL
-- INSERT INTO INT2_TBL VALUES ('34.5');

-- largest and smallest values
INSERT INTO INT2_TBL VALUES ('32767');

INSERT INTO INT2_TBL VALUES ('-32767');

-- bad input values -- should give errors
-- INSERT INTO INT2_TBL VALUES ('100000');
-- INSERT INTO INT2_TBL VALUES ('asdf');
-- INSERT INTO INT2_TBL VALUES (' ');
-- INSERT INTO INT2_TBL VALUES ('- 1234');
-- INSERT INTO INT2_TBL VALUES ('4 444');
-- INSERT INTO INT2_TBL VALUES ('123 dt');
-- INSERT INTO INT2_TBL VALUES ('');


SELECT '' AS five, * FROM INT2_TBL;

SELECT '' AS four, i.* FROM INT2_TBL i WHERE i.f1 <> smallint('0');

SELECT '' AS four, i.* FROM INT2_TBL i WHERE i.f1 <> int('0');

SELECT '' AS one, i.* FROM INT2_TBL i WHERE i.f1 = smallint('0');

SELECT '' AS one, i.* FROM INT2_TBL i WHERE i.f1 = int('0');

SELECT '' AS two, i.* FROM INT2_TBL i WHERE i.f1 < smallint('0');

SELECT '' AS two, i.* FROM INT2_TBL i WHERE i.f1 < int('0');

SELECT '' AS three, i.* FROM INT2_TBL i WHERE i.f1 <= smallint('0');

SELECT '' AS three, i.* FROM INT2_TBL i WHERE i.f1 <= int('0');

SELECT '' AS two, i.* FROM INT2_TBL i WHERE i.f1 > smallint('0');

SELECT '' AS two, i.* FROM INT2_TBL i WHERE i.f1 > int('0');

SELECT '' AS three, i.* FROM INT2_TBL i WHERE i.f1 >= smallint('0');

SELECT '' AS three, i.* FROM INT2_TBL i WHERE i.f1 >= int('0');

-- positive odds
SELECT '' AS one, i.* FROM INT2_TBL i WHERE (i.f1 % smallint('2')) = smallint('1');

-- any evens
SELECT '' AS three, i.* FROM INT2_TBL i WHERE (i.f1 % int('2')) = smallint('0');

-- [SPARK-28024] Incorrect value when out of range
SELECT '' AS five, i.f1, i.f1 * smallint('2') AS x FROM INT2_TBL i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's comment out line 68 since this should throw ERROR: smallint out of range.


SELECT '' AS five, i.f1, i.f1 * smallint('2') AS x FROM INT2_TBL i
WHERE abs(f1) < 16384;

SELECT '' AS five, i.f1, i.f1 * int('2') AS x FROM INT2_TBL i;

-- [SPARK-28024] Incorrect value when out of range
SELECT '' AS five, i.f1, i.f1 + smallint('2') AS x FROM INT2_TBL i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto for this due to ERROR: smallint out of range.


SELECT '' AS five, i.f1, i.f1 + smallint('2') AS x FROM INT2_TBL i
WHERE f1 < 32766;

SELECT '' AS five, i.f1, i.f1 + int('2') AS x FROM INT2_TBL i;

-- [SPARK-28024] Incorrect value when out of range
SELECT '' AS five, i.f1, i.f1 - smallint('2') AS x FROM INT2_TBL i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto due to ERROR: smallint out of range


SELECT '' AS five, i.f1, i.f1 - smallint('2') AS x FROM INT2_TBL i
WHERE f1 > -32767;

SELECT '' AS five, i.f1, i.f1 - int('2') AS x FROM INT2_TBL i;

-- The result is different because [SPARK-2659]
SELECT '' AS five, i.f1, i.f1 / smallint('2') AS x FROM INT2_TBL i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of SPARK-2659, we already made a decision and will not change. So, let's use div' instead of /. I believe this is the same reason why we use smallint('2')instead ofint2 '2'`

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should be adjusted accordingly like this.

- The result is different because [SPARK-2659]
+ PostgreSQL `/` is the same with Spark `div` since SPARK-2659.


-- The result is different because [SPARK-2659]
SELECT '' AS five, i.f1, i.f1 / int('2') AS x FROM INT2_TBL i;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.


-- corner cases
SELECT string(shiftleft(smallint(-1), 15));
SELECT string(smallint(shiftleft(smallint(-1), 15))+1);

-- check sane handling of INT16_MIN overflow cases
-- [SPARK-28024] Incorrect numeric values when out of range
-- SELECT smallint((-32768)) * smallint(-1);
-- SELECT smallint(-32768) / smallint(-1);
SELECT smallint(-32768) % smallint(-1);

-- [SPARK-28028] Cast numeric to integral type need round
-- check rounding when casting from float
SELECT x, smallint(x) AS int2_value
FROM (VALUES float(-2.5),
float(-1.5),
float(-0.5),
float(0.0),
float(0.5),
float(1.5),
float(2.5)) t(x);

-- check rounding when casting from numeric
SELECT x, smallint(x) AS int2_value
FROM (VALUES decimal(-2.5),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not have numeric type, can we use decimal?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to use DecimalType.SYSTEM_DEFAULT:

case "numeric" | "decimal" =>
// SPARK-26538: handle numeric without explicit precision and scale.
Some(DecimalType. SYSTEM_DEFAULT)

decimal(-1.5),
decimal(-0.5),
decimal(0.0),
decimal(0.5),
decimal(1.5),
decimal(2.5)) t(x);
Loading