[SPARK-27222][SQL] Support Instant and LocalDate in Literal.apply #24161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
ok to test |
Member
|
add to whitelist |
|
Test build #103739 has finished for PR 24161 at commit
|
|
Test build #103745 has finished for PR 24161 at commit
|
|
Test build #103753 has finished for PR 24161 at commit
|
Member
Author
|
@cloud-fan Could you take a look at this PR, please. |
HyukjinKwon
approved these changes
Mar 21, 2019
srowen
reviewed
Mar 21, 2019
Member
srowen
left a comment
srowen
left a comment
There was a problem hiding this comment.
Seems reasonable to me, but I don't know this part well
Contributor
|
thanks, merging to master! |
cloud-fan
reviewed
Mar 21, 2019
| } | ||
|
|
||
| test("construct literals from arrays of java.time.LocalDate") { | ||
| withSQLConf(SQLConf.DATETIME_JAVA8API_EANBLED.key -> "true") { |
Contributor
There was a problem hiding this comment.
not a big idea, but the behavior of literal is not controlled by this config right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to extend
Literal.applyto support constructing literals ofTimestampTypeandDateTypefromjava.time.Instantandjava.time.LocalDate. The java classes have been already supported as external types forTimestampTypeandDateTypeby the PRs #23811 and #23913.How was this patch tested?
Added new tests to
LiteralExpressionSuite.