[SPARK-27001][SQL][FOLLOW-UP] Drop Serializable in WalkedTypePath #23973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is a follow-up baed on the comment: #23908 (comment) |
Contributor
|
Maybe removing WalkedTypePath from logical plans would change the needs on Serializable. (Before that I clearly saw test failure when WalkedTypePath doesn't extend Serializable.) LGTM once the full build succeeds. |
cloud-fan
approved these changes
Mar 5, 2019
|
Test build #103036 has finished for PR 23973 at commit
|
cloud-fan
changed the title
Contributor
|
thanks, merging to master! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr tried to drop
SerializableinWalkedTypePath.How was this patch tested?
Pass Jenkins.