-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-26726] Synchronize the amount of memory used by the broadcast variable to the UI display #23649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[SPARK-26726] Synchronize the amount of memory used by the broadcast variable to the UI display #23649
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2459342
[SPARK-26726] The amount of memory used by the broadcast variable is …
httfighter a51ea3e
add the test case
httfighter e9d0f18
Improve code modification
httfighter 53cbc0b
Update the code
httfighter b4d6996
Update the code
httfighter 221bf77
Update AppStatusListener.scala
httfighter 2024976
Update AppStatusListener.scala
httfighter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -827,6 +827,7 @@ private[spark] class AppStatusListener( | |
| event.blockUpdatedInfo.blockId match { | ||
| case block: RDDBlockId => updateRDDBlock(event, block) | ||
| case stream: StreamBlockId => updateStreamBlock(event, stream) | ||
| case broadcast: BroadcastBlockId => updateBroadcastBlock(event, broadcast) | ||
| case _ => | ||
| } | ||
| } | ||
|
|
@@ -995,6 +996,30 @@ private[spark] class AppStatusListener( | |
| } | ||
| } | ||
|
|
||
| def updateBroadcastBlock(event: SparkListenerBlockUpdated, broadcast: BroadcastBlockId): Unit = { | ||
| val executorId = event.blockUpdatedInfo.blockManagerId.executorId | ||
| val storageLevel = event.blockUpdatedInfo.storageLevel | ||
|
|
||
| // Whether values are being added to or removed from the existing accounting. | ||
| val diskDelta = event.blockUpdatedInfo.diskSize * (if (storageLevel.useDisk) 1 else -1) | ||
| val memoryDelta = event.blockUpdatedInfo.memSize * (if (storageLevel.useMemory) 1 else -1) | ||
|
|
||
| // Function to apply a delta to a value, but ensure that it doesn't go negative. | ||
| def newValue(old: Long, delta: Long): Long = math.max(0, old + delta) | ||
|
||
|
|
||
| liveExecutors.get(executorId).foreach { exec => | ||
| if (exec.hasMemoryInfo) { | ||
|
||
| if (storageLevel.useOffHeap) { | ||
| exec.usedOffHeap = newValue(exec.usedOffHeap, memoryDelta) | ||
| } else { | ||
| exec.usedOnHeap = newValue(exec.usedOnHeap, memoryDelta) | ||
| } | ||
| } | ||
| exec.memoryUsed = newValue(exec.memoryUsed, memoryDelta) | ||
| exec.diskUsed = newValue(exec.diskUsed, diskDelta) | ||
| } | ||
| } | ||
|
|
||
| private def getOrCreateStage(info: StageInfo): LiveStage = { | ||
| val stage = liveStages.computeIfAbsent((info.stageId, info.attemptNumber), | ||
| new Function[(Int, Int), LiveStage]() { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
def->private def?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your review! I have submitted a new change.